www/apache25-devel: New port
AbandonedPublic
Actions

Authored by brnrd on Nov 15 2017, 10:34 PM.

Details

Reviewers

mat
lwhsu

Summary

www/apache25-devel: New port

 - Add upstream first alpha version of 2.5
 - Only tested with new Uses/apache.mk

Differential_Revision: D...

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 12769
Build 13037: arc lint + arc unit

Event Timeline

brnrd created this revision.Nov 15 2017, 10:34 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 15 2017, 10:34 PM

mat added inline comments.Nov 24 2017, 5:28 PM

www/apache25-devel/Makefile
4–5	DISTVERSION= 2.5.0-alpha So that the alpha is part of the package's version number.

More subtle issues emerged when building on i386 and 10.x.
There's also an issue with the uninstall. Fixing it!

www/apache25-devel/Makefile
4–5	Fixed

Do we really -devel suffix here? We already have 25 as the version suffix and I thought -devel is used for the port which tracks svn head or git master branches.
Name this port www/apache25 then we don't need to rename it when it comes to official release.
If we want to warn users this is a alpha release, we can put it into pkg-message or even COMMENT is we think it is necessary.

In D13111#277989, @lwhsu wrote:

Do we really -devel suffix here? We already have 25 as the version suffix and I thought -devel is used for the port which tracks svn head or git master branches.
Name this port www/apache25 then we don't need to rename it when it comes to official release.
If we want to warn users this is a alpha release, we can put it into pkg-message or even COMMENT is we think it is necessary.

Apache httpd releases are always even numbers, this will become apache26 eventually. The -devel suffix is there solely to make it abundantly explicit that you should not run this in production environments.
I want to make this a port to get as much early feedback on the port itself to be available prior to the release of apache httpd 2.6. I've removed all possible patches hoping to start with a clean slate.
It is my intention to svn rename this port to www/apache26 once upstream releases it.

In D13111#278085, @brnrd wrote:

Apache httpd releases are always even numbers, this will become apache26 eventually. The -devel suffix is there solely to make it abundantly explicit that you should not run this in production environments.
I want to make this a port to get as much early feedback on the port itself to be available prior to the release of apache httpd 2.6. I've removed all possible patches hoping to start with a clean slate.
It is my intention to svn rename this port to www/apache26 once upstream releases it.

Got it, this makes sense to me now.

It should probably be named apache-devel, without the version, so it could be used with apache 2.7 when 2.6 gets released.

mat added inline comments.Dec 4 2017, 12:50 PM

www/apache25-devel/pkg-plist
254–255	That seems strange.

brnrd marked an inline comment as done.Dec 5 2017, 7:38 AM

brnrd added inline comments.

www/apache25-devel/pkg-plist
254–255	It did to me as well, was on my TODO list to figure out. Found the corresponding commit upstream, this is intended behavior by the project. ab, logresolve, httxt2dbm and apxs have been moved from `sbin` to `bin` (in 2011). Adjusted locally for both apxs and dbmanage (ab and logresolve already done)

brnrd added reviewers: mat, lwhsu.Dec 5 2017, 7:39 AM

In D13111#278882, @mat wrote:

It should probably be named apache-devel, without the version, so it could be used with apache 2.7 when 2.6 gets released.

That would be perfectly fine for me, but looking at the historical performance of the httpd project it will take years before a next version is carved.
2011-11-15 We're now on 2.5.0 ...
2012-02-19 2.4.1 released
2009-01-03 2.3.1-dev tagged
2008-10-14 2.2.10 released
2004-11-20 2.1.1-dev tagged
That would mean we'd have a defunct -devel port in the tree for many years which should result in deletion. Therefore I opted to use apache25-devel to make the non-prod status explicit and rename to apache26 once it is released GA.

brnrd mentioned this in D12308: Mk/Uses/apache.mk: Port from Mk/bsd.apache.mk.Dec 10 2017, 8:58 PM

joneum added a subscriber: joneum.Jan 15 2018, 10:47 AM

Although it looks good to me, I am not sure I am qualified to approve this. Can anyone from apache@ team check this?

My problem: i can not importing this revision in an extra, new generated porttree ~/dev/apache25:

With "arc patch D13111": http://dpaste.com/0WWTA0Y

and when i download the patch and will importing via "patch -p 0": http://dpaste.com/3S09S5F

Is my only option to do it all by hand?

This review was intended to be there to test TLSv1.3 with Apache.

There's work underway to add TLSv1.3 support to 2.4.34 instead, so the current push to have this around has kind of gone.
See https://svn.apache.org/viewvc/httpd/httpd/branches/tlsv1.3-for-2.4.x/

Let's see if that branch gets sufficient votes to get it into a next point-release of Apache.

Abandoning this review. The main objective was to have an Apache that would work with OpenSSL 1.1 (and LibreSSL 2.7+) and support for TLSv1.3. Both these objectives have been/will be met by the 2.4 branch. As for the TLSv1.3 support, the discussions on apache httpd-dev mailing-list suggest that TLSv1.3 will land in a point-release of 2.4. Outlook on 2.6.x, for which 2.5 is the development branch, are that there won't be such a release soon.
2.4.x+TLSv1.3 branch (or git slave repo if you are so inclined)
Voting/discussion thread on http-dev mailing-list
Currently TLSv1.3 support is non-functional with released browsers, the browsers only support draft-13 and or 18. Testing requires BETA, nightly or canary builds. This will soon change.