Page MenuHomeFreeBSD

New port: science/erd: AcesIII electron repulsion integrals
ClosedPublic

Authored by yuri on Nov 14 2017, 9:05 AM.
Tags
None
Referenced Files
F114757883: D13080.id35247.diff
Wed, Apr 16, 11:00 AM
Unknown Object (File)
Tue, Apr 15, 8:15 PM
Unknown Object (File)
Mon, Apr 14, 7:35 PM
Unknown Object (File)
Wed, Apr 2, 12:07 PM
Unknown Object (File)
Mar 6 2025, 8:34 AM
Unknown Object (File)
Mar 4 2025, 5:34 AM
Unknown Object (File)
Mar 2 2025, 1:46 PM
Unknown Object (File)
Feb 28 2025, 7:55 PM
Subscribers

Details

Summary

To support psi4 quantunm chemistry package

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

science/erd/Makefile
19 ↗(On Diff #35223)

^ it looks weird to set empty with +=
[though I also like the symmetry :D ]

Probably you should prefer:

CMAKE_ARGS= -DBUILD...\
            -DENABLE...
yuri marked an inline comment as done.Nov 14 2017, 6:02 PM
yuri added inline comments.
science/erd/Makefile
19 ↗(On Diff #35223)

Besides symmetry, individual lines are easier to remove/comment out. And the price is only a few extra characters.

Do you still think it should be changed?

science/erd/Makefile
19 ↗(On Diff #35223)

Even though it pains me, yes :-)

yuri marked an inline comment as done.

Changed CMAKE_ARGS. We can live with the pain.

yuri marked 2 inline comments as done.Nov 14 2017, 6:19 PM
This revision is now accepted and ready to land.Nov 14 2017, 6:24 PM
This revision was automatically updated to reflect the committed changes.