Page MenuHomeFreeBSD

New port: science/erd: AcesIII electron repulsion integrals
ClosedPublic

Authored by yuri on Nov 14 2017, 9:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 9:09 AM
Unknown Object (File)
Tue, Nov 12, 11:39 AM
Unknown Object (File)
Thu, Nov 7, 12:11 PM
Unknown Object (File)
Oct 19 2024, 1:54 AM
Unknown Object (File)
Oct 16 2024, 5:52 AM
Unknown Object (File)
Oct 1 2024, 4:56 PM
Unknown Object (File)
Sep 29 2024, 10:14 PM
Unknown Object (File)
Sep 11 2024, 3:53 AM
Subscribers

Details

Summary

To support psi4 quantunm chemistry package

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

science/erd/Makefile
19 ↗(On Diff #35223)

^ it looks weird to set empty with +=
[though I also like the symmetry :D ]

Probably you should prefer:

CMAKE_ARGS= -DBUILD...\
            -DENABLE...
yuri marked an inline comment as done.Nov 14 2017, 6:02 PM
yuri added inline comments.
science/erd/Makefile
19 ↗(On Diff #35223)

Besides symmetry, individual lines are easier to remove/comment out. And the price is only a few extra characters.

Do you still think it should be changed?

science/erd/Makefile
19 ↗(On Diff #35223)

Even though it pains me, yes :-)

yuri marked an inline comment as done.

Changed CMAKE_ARGS. We can live with the pain.

yuri marked 2 inline comments as done.Nov 14 2017, 6:19 PM
This revision is now accepted and ready to land.Nov 14 2017, 6:24 PM
This revision was automatically updated to reflect the committed changes.