New port: science/erd: AcesIII electron repulsion integrals
ClosedPublic

Authored by yuri on Tue, Nov 14, 9:05 AM.

Details

Summary

To support psi4 quantunm chemistry package

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yuri created this revision.Tue, Nov 14, 9:05 AM
tcberner added inline comments.Tue, Nov 14, 5:49 PM
science/erd/Makefile
19 ↗(On Diff #35223)

^ it looks weird to set empty with +=
[though I also like the symmetry :D ]

Probably you should prefer:

CMAKE_ARGS= -DBUILD...\
            -DENABLE...
yuri marked an inline comment as done.Tue, Nov 14, 6:02 PM
yuri added inline comments.
science/erd/Makefile
19 ↗(On Diff #35223)

Besides symmetry, individual lines are easier to remove/comment out. And the price is only a few extra characters.

Do you still think it should be changed?

tcberner added inline comments.Tue, Nov 14, 6:15 PM
science/erd/Makefile
19 ↗(On Diff #35223)

Even though it pains me, yes :-)

yuri updated this revision to Diff 35247.Tue, Nov 14, 6:18 PM
yuri marked an inline comment as done.

Changed CMAKE_ARGS. We can live with the pain.

yuri marked 2 inline comments as done.Tue, Nov 14, 6:19 PM
tcberner accepted this revision.Tue, Nov 14, 6:24 PM
This revision is now accepted and ready to land.Tue, Nov 14, 6:24 PM
This revision was automatically updated to reflect the committed changes.