evdev: USB scancode 0x54 is KEY_KPSLASH, not KEY_SLASH
ClosedPublic
Actions

Authored by dumbbell on Nov 7 2017, 9:11 PM.

Details

Reviewers

gonzo
wulf

Commits

rS326021: evdev: change USB scancode 0x54 from KEY_SLASH to KEY_KPSLASH

Summary

This is the key between KEY_NUMLOCK and KEY_KPASTERISK at the top of a numpad.

Without the patch, it incorrectly behaves exactly like the key on the left of the Right Shift.

Test Plan

Tested with a 105-keys USB keyboard.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12546
Build 12821: arc lint + arc unit

Event Timeline

dumbbell created this revision.Nov 7 2017, 9:11 PM

Harbormaster completed remote builds in B12546: Diff 34900.Nov 7 2017, 9:11 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 7 2017, 9:11 PM

LGTM.

This revision is now accepted and ready to land.Nov 8 2017, 7:03 AM

LGTM

Closed by commit rS326021: evdev: change USB scancode 0x54 from KEY_SLASH to KEY_KPSLASH (authored by wulf). · Explain WhyNov 20 2017, 7:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

evdev/

evdev_utils.c

2 lines

Diff 34900

View Options

sys/dev/evdev/evdev_utils.c

evdev: USB scancode 0x54 is KEY_KPSLASH, not KEY_SLASHClosedPublicActions