Document MACHINE, MACHINE_ARCH, TARGET and TARGET_ARCH historical use and general philosphy.
ClosedPublic
Actions

Authored by imp on Nov 7 2017, 6:34 PM.

Details

Reviewers

emaste
bdrewery

Commits

rS325749: Document MACHINE, MACHINE_ARCH, CPUTYPE, TARGET and TARGET_ARCH

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Nov 7 2017, 6:34 PM

Harbormaster completed remote builds in B12537: Diff 34890.Nov 7 2017, 6:34 PM

imp added a reviewer: emaste.Nov 7 2017, 6:37 PM

Two textual suggestions. Thanks for documenting this.

share/man/man7/arch.7
347 ↗	(On Diff #34890)	Hmm, the two instances of internal(ly) sound a bit redundant. Maybe one of these two would fit better? a) ... there are some internal variables that are used within the build system ... b) ... there are some variables that are used internally to the build system ...
408 ↗	(On Diff #34890)	s/names/name/

bdrewery added a subscriber: bdrewery.Nov 7 2017, 9:06 PM

imp added inline comments.Nov 7 2017, 9:11 PM

share/man/man7/arch.7
347 ↗	(On Diff #34890)	Good point.
408 ↗	(On Diff #34890)	I originally had 'no standarized names' but made it shorter w/o fixing the plural.

imp added a reviewer: bdrewery.Nov 7 2017, 9:12 PM

bdrewery added inline comments.Nov 7 2017, 9:28 PM

share/man/man7/arch.7
348 ↗	(On Diff #34890)	I would end at "the build system". The rest feels redundant in a manpage.
394 ↗	(On Diff #34890)	need to newline wrap the `.Dv`
410 ↗	(On Diff #34890)	Does Fx work there like that?
412 ↗	(On Diff #34890)	It unfortunately is but as you say should not be relied on.
416 ↗	(On Diff #34890)	newline wrap `.Dv`

imp added inline comments.Nov 8 2017, 2:36 PM

share/man/man7/arch.7
348 ↗	(On Diff #34890)	ok
394 ↗	(On Diff #34890)	I think I can just remove the . and be good. Either way, I'll fix.
410 ↗	(On Diff #34890)	Yes.
416 ↗	(On Diff #34890)	OK. Will remove the . or fix.

Update, per feedback

Closed by commit rS325749: Document MACHINE, MACHINE_ARCH, CPUTYPE, TARGET and TARGET_ARCH (authored by imp). · Explain WhyNov 13 2017, 12:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man7/

arch.7

84 lines

Diff 35181

View Options

head/share/man/man7/arch.7

Document MACHINE, MACHINE_ARCH, TARGET and TARGET_ARCH historical use and general philosphy.ClosedPublicActions