Switch to <opt>_CMAKE_BOOL

[adridg]

Summary

Options which translate to CMake arguments -D<content>:BOOL=<ON|OFF>
can be simplified through the use of <opt>_CMAKE_BOOL.

This does remind me that this mechanism isn't documented in the
Porter's handbook.

[tcberner]

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#options-cmake_bool it's documented here

[tcberner]

databases/soci/Makefile

49 ↗

(On Diff #34800)

You could use it here to and fix the cmake file to use the proper path probably

[adridg]

databases/soci/Makefile

49 ↗

(On Diff #34800)

This strikes me as a less invasive approach: we prefer libodbc over libiodbc which CMake will find, but that's just a packaging preference. Patching the CMakeLists (or more likely cmake/modules/FindODBC.cmake) is a larger change, and less likely to apply cleanly to future releases.

[adridg]

Minor updates

• bump PORTREVISION
• massage COMMENT

[adridg]

MAINTAINER should be a reviewer, not just subscribed.

[tcberner]

databases/soci/Makefile

49 ↗

(On Diff #34800)

Ah. Thanks.

But shouldn't

ODBC_CMAKE_BOOL=WITH_ODBC
ODBC_CMAKE_ON= -DODBC_LIBRARY:FILE_PATH=${LOCALBASE}/lib/libodbc.so

work, so that all toggles are CMAKE_BOOL's

[adridg]

Simplify ODBC options as well. You can combine _BOOL with _ON.

[jlaffaye]

LGTM

[rakuco]

lgtm, but the PORTREVISION bump can be dropped, as this change is just cosmetic.

[adridg]

No need to bump PORTREVISION, cosmetic change in Makefile only.