Add 0xb OR opcode support to bhyve's instruction emulation
ClosedPublic
Actions

Authored by grehan on Oct 30 2017, 7:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 29 2024, 2:40 PM

	Unknown Object (File)
	Nov 21 2024, 6:44 AM

	Unknown Object (File)
	Oct 5 2024, 1:33 PM

	Unknown Object (File)
	Sep 28 2024, 10:49 AM

	Unknown Object (File)
	Sep 24 2024, 10:02 PM

	Unknown Object (File)
	Sep 22 2024, 3:44 PM

	Unknown Object (File)
	Sep 22 2024, 1:25 PM

	Unknown Object (File)
	Sep 20 2024, 11:25 AM

View All 42 Files

Subscribers

araujo

imp

Details

Reviewers

araujo

Group Reviewers

bhyve

Commits

rS325261: Emulate the "OR reg, r/m" instruction (opcode 0BH).

Summary

The FreeBSD HDA code uses the 0xb variant of OR when accessing
device registers. Add this emulation, using the pattern of
existing OR code.

Test Plan

Run the HDA emulation patch with a FreeBSD 11.1 guest, and cat a .wav
file to /dev/dsp.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

grehan created this revision.Oct 30 2017, 7:17 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 30 2017, 7:17 AM

Harbormaster completed remote builds in B12296: Diff 34447.Oct 30 2017, 7:17 AM

LGTM!

This revision is now accepted and ready to land.Oct 30 2017, 7:28 AM

Closed by commit rS325261: Emulate the "OR reg, r/m" instruction (opcode 0BH). (authored by grehan). · Explain WhyNov 1 2017, 3:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

vmm/

vmm_instruction_emul.c

32 lines

Diff 34577

View Options

head/sys/amd64/vmm/vmm_instruction_emul.c

Add 0xb OR opcode support to bhyve's instruction emulationClosedPublicActions