Differential D12816

Fix qt5 builds on some arm architectures
ClosedPublic
Actions

Authored by tcberner on Oct 28 2017, 4:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 23, 6:31 AM

	Unknown Object (File)
	Sat, Dec 7, 8:47 PM

	Unknown Object (File)
	Sat, Dec 7, 8:47 PM

	Unknown Object (File)
	Sat, Dec 7, 8:47 PM

	Unknown Object (File)
	Sat, Dec 7, 8:47 PM

	Unknown Object (File)
	Sat, Dec 7, 8:47 PM

	Unknown Object (File)
	Sat, Dec 7, 8:35 PM

	Unknown Object (File)
	Sun, Dec 1, 9:21 PM

Subscribers

Details

Reviewers

rakuco
mmel
mikael

Group Reviewers

Commits

rP453418: Fix qt5 builds on some arm architectures

Summary

I don't think there is a need to bump revisions (it did not build on these architectures,
and should not affect the others).

Test Plan

Exp-run to be on the safe side: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223289

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tcberner created this revision.Oct 28 2017, 4:20 PM

Owners added a reviewer: O5: Ports Framework.Oct 28 2017, 4:20 PM

Herald added a reviewer: portmgr. · View Herald TranscriptOct 28 2017, 4:20 PM

Herald added a subscriber: mat. · View Herald Transcript

... one should read the patch and apply it in the proper directory :)

Harbormaster completed remote builds in B12281: Diff 34418.Oct 28 2017, 4:24 PM

Add some context to patches.

tcberner edited the test plan for this revision. (Show Details)Oct 28 2017, 4:37 PM

mat removed reviewers: O5: Ports Framework, portmgr.Oct 30 2017, 12:31 PM

mmel accepted this revision.Oct 30 2017, 1:16 PM

mmel added inline comments.

www/qt5-webkit/files/patch-Source_JavaScriptCore_offlineasm_arm.rb
1 ↗	(On Diff #34419)	armv6/v7:
3 ↗	(On Diff #34419)	Don't emit ARMv7 instructions (movw, movt) for ARMv6 targets.
www/qt5-webkit/files/patch-Source_WebCore_platform_graphics_cpu_arm_filters_FELightingNEON.cpp
1 ↗	(On Diff #34419)	armv6/v7:
3 ↗	(On Diff #34419)	Use correct UAL syntax for 'vmov rx, ry,...' instruction. The '.u32' modifier in not allowed for this operand combination by ARM ARM, but gas silently ignores it.

This revision is now accepted and ready to land.Oct 30 2017, 1:16 PM

mikael accepted this revision.Oct 30 2017, 1:18 PM

Seems that exp-run passed without problems. Can you, please, commit this ?

sorry, I had a busy week, I plan to do it tonigt

Closed by commit rP453418: Fix qt5 builds on some arm architectures (authored by tcberner). · Explain WhyNov 3 2017, 6:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

3 lines

O5: Ports Framework

devel/

qt5/

files/

extrapatch-config.tests_unix_arch.test

15 lines

www/

qt5-webkit/

files/

patch-Source_JavaScriptCore_assembler_ARMAssembler.h

14 lines

patch-Source_JavaScriptCore_assembler_ARMv7Assembler.h

14 lines

patch-Source_JavaScriptCore_offlineasm_arm.rb

20 lines

patch-Source_WTF_wtf_Platform.h

24 lines

patch-Source_WebCore_platform_graphics_cpu_arm_filters_FELightingNEON.cpp

18 lines

patch-Source_bmalloc_bmalloc_BPlatform.h

24 lines

Diff 34730

head/Mk/bsd.qt.mk

Loading...

head/devel/qt5/files/extrapatch-config.tests_unix_arch.test

Loading...

head/www/qt5-webkit/files/patch-Source_JavaScriptCore_assembler_ARMAssembler.h

Loading...

head/www/qt5-webkit/files/patch-Source_JavaScriptCore_assembler_ARMv7Assembler.h

Loading...

head/www/qt5-webkit/files/patch-Source_JavaScriptCore_offlineasm_arm.rb

Loading...

head/www/qt5-webkit/files/patch-Source_WTF_wtf_Platform.h

Loading...

head/www/qt5-webkit/files/patch-Source_WebCore_platform_graphics_cpu_arm_filters_FELightingNEON.cpp

Loading...

head/www/qt5-webkit/files/patch-Source_bmalloc_bmalloc_BPlatform.h

Loading...