Zero uninitialized part of struct ptrace_lwpinfo.
ClosedPublic
Actions

Authored by kib on Oct 26 2017, 2:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Oct 3 2024, 12:05 PM

	Unknown Object (File)
	Oct 3 2024, 12:54 AM

	Unknown Object (File)
	Oct 2 2024, 12:13 AM

	Unknown Object (File)
	Sep 29 2024, 7:22 PM

	Unknown Object (File)
	Sep 24 2024, 3:51 AM

	Unknown Object (File)
	Sep 8 2024, 2:15 AM

	Unknown Object (File)
	Sep 8 2024, 12:34 AM

	Unknown Object (File)
	Sep 7 2024, 4:27 PM

View All 52 Files

Subscribers

imp

Details

Reviewers

jhb

Commits

rS325567: Zero whole struct ptrace_lwpinfo to not leak kernel stack data.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 26 2017, 2:29 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 26 2017, 2:29 PM

kib mentioned this in D12794: Discard the correct thread event reported for a ptrace stop..Oct 26 2017, 2:31 PM

jhb added inline comments.Nov 6 2017, 8:42 PM

sys/kern/sys_process.c
1363 ↗	(On Diff #34355)	I would be inclined to zero the whole struct. In my case I saw garbage leak in 'pl_child_pid' for a non-fork event. We should probably zero the entire pl32 before copying across as well in case there is padding (perhaps in fields added in the future)?

Zero the whole struct ptrace_lwpinfo and ptrace_lwpinfo32.

jhb accepted this revision.Nov 8 2017, 10:10 PM

This revision is now accepted and ready to land.Nov 8 2017, 10:10 PM

Closed by commit rS325567: Zero whole struct ptrace_lwpinfo to not leak kernel stack data. (authored by kib). · Explain WhyNov 8 2017, 11:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

sys_process.c

4 lines

Diff 34961

View Options

head/sys/kern/sys_process.c

Zero uninitialized part of struct ptrace_lwpinfo.ClosedPublicActions