Page MenuHomeFreeBSD

devel/hg-git: Update from 0.8.6 to 0.8.9
ClosedPublic

Authored by joneum on Oct 18 2017, 9:16 AM.

Details

Summary

devel/hg-git: Update from 0.8.6 to 0.8.9

While here, switch it to DISTVERISON

PR: 222494
Reported by: xmj
Approved by: maintainer timeout (2 weeks) xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

~/dev/ports/devel/hg-git % portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 2 warnings found.

poudriere testport:

10.3-amd64
10.3-i386
11.1-amd64
11.1-i386
12.0-CURRENT r323123 amd64
12.0-CURRENT r323123 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joneum created this revision.Oct 18 2017, 9:16 AM
mat added a comment.Oct 18 2017, 3:04 PM

maintainer timeout is 14 days, 2 weeks, no need to specify the amount of time that elapsed as long as it is more that 14 days.

joneum edited the summary of this revision. (Show Details)Oct 18 2017, 3:11 PM

Also, as the DISTANME is rather non-descriptive, how about giving it a DIST_SUBDIR?

devel/hg-git/Makefile
5 ↗(On Diff #34094)

You could probably change this to DISTVERSION while here

joneum updated this revision to Diff 34122.Oct 18 2017, 8:19 PM

change to DISTVERSION

tcberner added inline comments.Oct 19 2017, 5:44 PM
devel/hg-git/Makefile
16 ↗(On Diff #34122)

^ that PKGNAMEPREFIX also looks rather strange -- I think it would be better to use ${PYTHON_PKGNAMEPREFIX} directly as usual.

joneum updated this revision to Diff 34149.Oct 19 2017, 5:49 PM

switch to ${PYTHON_PKGNAMEPREFIX}

joneum updated this revision to Diff 34150.Oct 19 2017, 6:01 PM

Add DIST_SUBDIR into the Makefile

joneum updated this revision to Diff 34151.Oct 19 2017, 6:04 PM

renew the distinfo

joneum edited the summary of this revision. (Show Details)Oct 19 2017, 6:14 PM

Looks good to me, after the maintainer gives his OK.

tcberner accepted this revision.Oct 19 2017, 6:23 PM

Sorry my bad, didn't see the age of the PR.

This revision is now accepted and ready to land.Oct 19 2017, 6:23 PM
This revision was automatically updated to reflect the committed changes.