Page MenuHomeFreeBSD

match sendfile() error handling to send()
ClosedPublic

Authored by jason_eggnet.com on Oct 10 2017, 12:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 12:40 AM
Unknown Object (File)
Fri, Oct 10, 8:56 PM
Unknown Object (File)
Thu, Oct 9, 3:13 PM
Unknown Object (File)
Fri, Oct 3, 2:53 PM
Unknown Object (File)
Tue, Sep 30, 6:28 AM
Unknown Object (File)
Sat, Sep 27, 4:35 AM
Unknown Object (File)
Fri, Sep 19, 6:25 AM
Unknown Object (File)
Wed, Sep 17, 12:22 AM
Subscribers

Details

Summary

Per Gleb Smirnoff <glebius@freebsd.org> sendfile() should match
the error checking order of send() which is currently:

SBS_CANTSENDMORE
so_error
SS_ISCONNECTED

This will hide ECONNRESET relative to the previous patch, but it will
be exposed as EPIPE like send() instead of ENOTCONN.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

My suggestion is to commit in two patches. First, revert r324405. Second, move of SS_ISCONNECTED check.

This revision is now accepted and ready to land.Oct 10 2017, 12:15 AM
This revision now requires review to proceed.Oct 10 2017, 12:56 AM

Ok, Sean just reverted the previous patch, and this patch is based on the new HEAD.

I'm sorry for accepting the previous patch too fast, without investing time into proper review.

This revision is now accepted and ready to land.Oct 10 2017, 8:03 PM
This revision was automatically updated to reflect the committed changes.