Differential D12633

match sendfile() error handling to send()
ClosedPublic
Actions

Authored by jason_eggnet.com on Oct 10 2017, 12:07 AM.

Details

Reviewers

glebius

Group Reviewers

transport

Commits

rS324508: match sendfile() error handling to send().

Summary

Per Gleb Smirnoff <glebius@freebsd.org> sendfile() should match
the error checking order of send() which is currently:

SBS_CANTSENDMORE
so_error
SS_ISCONNECTED

This will hide ECONNRESET relative to the previous patch, but it will
be exposed as EPIPE like send() instead of ENOTCONN.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jason_eggnet.com created this revision.Oct 10 2017, 12:07 AM

My suggestion is to commit in two patches. First, revert r324405. Second, move of SS_ISCONNECTED check.

This revision is now accepted and ready to land.Oct 10 2017, 12:15 AM

rebase patch to new HEAD

This revision now requires review to proceed.Oct 10 2017, 12:56 AM

Ok, Sean just reverted the previous patch, and this patch is based on the new HEAD.

jch added a subscriber: jch.Oct 10 2017, 7:22 AM

I'm sorry for accepting the previous patch too fast, without investing time into proper review.

This revision is now accepted and ready to land.Oct 10 2017, 8:03 PM

No problem, thanks :)

Closed by commit rS324508: match sendfile() error handling to send(). (authored by sbruno). · Explain WhyOct 10 2017, 10:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_sendfile.c

8 lines

Diff 33872

View Options

head/sys/kern/kern_sendfile.c

match sendfile() error handling to send()ClosedPublicActions