Page MenuHomeFreeBSD

match sendfile() error handling to send()
ClosedPublic

Authored by jason_eggnet.com on Oct 10 2017, 12:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:33 AM
Unknown Object (File)
Dec 10 2023, 12:15 PM
Unknown Object (File)
Nov 9 2023, 4:04 PM
Unknown Object (File)
Oct 15 2023, 7:01 PM
Unknown Object (File)
Oct 10 2023, 6:40 PM
Unknown Object (File)
Sep 11 2023, 8:53 PM
Unknown Object (File)
Aug 15 2023, 12:14 PM
Unknown Object (File)
Jun 24 2023, 7:32 AM
Subscribers

Details

Summary

Per Gleb Smirnoff <glebius@freebsd.org> sendfile() should match
the error checking order of send() which is currently:

SBS_CANTSENDMORE
so_error
SS_ISCONNECTED

This will hide ECONNRESET relative to the previous patch, but it will
be exposed as EPIPE like send() instead of ENOTCONN.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

My suggestion is to commit in two patches. First, revert r324405. Second, move of SS_ISCONNECTED check.

This revision is now accepted and ready to land.Oct 10 2017, 12:15 AM
This revision now requires review to proceed.Oct 10 2017, 12:56 AM

Ok, Sean just reverted the previous patch, and this patch is based on the new HEAD.

I'm sorry for accepting the previous patch too fast, without investing time into proper review.

This revision is now accepted and ready to land.Oct 10 2017, 8:03 PM
This revision was automatically updated to reflect the committed changes.