Page MenuHomeFreeBSD

patch(1): Don't overrun line buffer if line is not completely malformed
ClosedPublic

Authored by kevans on Oct 6 2017, 4:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 5:27 PM
Unknown Object (File)
Mon, Oct 20, 3:46 AM
Unknown Object (File)
Mon, Oct 20, 3:46 AM
Unknown Object (File)
Mon, Oct 20, 3:46 AM
Unknown Object (File)
Sun, Oct 19, 1:07 PM
Unknown Object (File)
Sat, Oct 18, 1:32 AM
Unknown Object (File)
Wed, Sep 24, 7:24 PM
Unknown Object (File)
Sep 13 2025, 8:03 AM
Subscribers

Details

Summary

Patches like file.txt attached to PR 190195 with a final line formed
like ">(EOL)" could cause a copy past the end of the current line buffer. In the
case of PR 191641, this caused a duplicate line to be copied into the resulting
file.

Instead of running past the end, treat it as if it were a blank line.

PR: 191641

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Whoops, it's still possible to run out of memory there, and this looks a little
cleaner

This revision is now accepted and ready to land.Oct 7 2017, 3:36 AM
This revision was automatically updated to reflect the committed changes.