Page MenuHomeFreeBSD

patch(1): Don't overrun line buffer if line is not completely malformed
ClosedPublic

Authored by kevans on Oct 6 2017, 4:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 2:48 PM
Unknown Object (File)
Fri, Nov 1, 5:17 PM
Unknown Object (File)
Oct 19 2024, 12:22 PM
Unknown Object (File)
Oct 5 2024, 2:20 AM
Unknown Object (File)
Oct 2 2024, 8:02 AM
Unknown Object (File)
Sep 19 2024, 4:59 AM
Unknown Object (File)
Sep 18 2024, 4:25 PM
Unknown Object (File)
Sep 10 2024, 10:34 PM
Subscribers

Details

Summary

Patches like file.txt attached to PR 190195 with a final line formed
like ">(EOL)" could cause a copy past the end of the current line buffer. In the
case of PR 191641, this caused a duplicate line to be copied into the resulting
file.

Instead of running past the end, treat it as if it were a blank line.

PR: 191641

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Whoops, it's still possible to run out of memory there, and this looks a little
cleaner

This revision is now accepted and ready to land.Oct 7 2017, 3:36 AM
This revision was automatically updated to reflect the committed changes.