Page MenuHomeFreeBSD

devel/py-gitpython: updating to 2.1.7 version.
ClosedPublic

Authored by rigoletto on Oct 4 2017, 1:03 AM.
Tags
Referenced Files
Unknown Object (File)
Jan 12 2024, 5:48 PM
Unknown Object (File)
Dec 31 2023, 10:33 AM
Unknown Object (File)
Dec 20 2023, 2:59 AM
Unknown Object (File)
Nov 10 2023, 12:47 PM
Unknown Object (File)
Nov 6 2023, 10:09 PM
Unknown Object (File)
Nov 4 2023, 9:08 PM
Unknown Object (File)
Nov 4 2023, 8:56 PM
Unknown Object (File)
Nov 4 2023, 3:45 PM

Details

Summary
  • update to 2.1.7 version
  • switch to DISTVERSION

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11896
Build 12231: arc lint + arc unit

Event Timeline

Upstream is confused about devel/py-gitdb requirement: setup.py require "devel/py-gitdb2" but in requirements.txt tell "devel/py-gitdb".

Based on the current (old) port, I assumed upstream requirements.txt is outdated, since the version required in that file is old and the same of the rather outdated currently available port..

A closer look in the setup.py and it seems flake8 nor coverage are actually not necessary.

Removing py-coverage and py-flake8 from TEST_DEPENDS.

tcberner removed a reviewer: tcberner.

Oki, looking good

This revision is now accepted and ready to land.Oct 5 2017, 6:05 AM
sunpoet requested changes to this revision.Oct 6 2017, 10:22 AM
sunpoet added a subscriber: sunpoet.
sunpoet added inline comments.
devel/py-gitpython/Makefile
17

According to requirements.txt, unittest2 is required for python 2.6 or below.

24

Use do-test: instead.

This revision now requires changes to proceed.Oct 6 2017, 10:22 AM

Remove the devel/py-unittest2 dependency, switch 'regression-test:' to 'do-test:'.

devel/py-gitpython/Makefile
22

It's good to add USE_PYTHON=concurrent which allows installing this port with different python versions at the same time.

24

Sorry for not being clear enough.
I meant to replace the whole line with "do-test:" since it is part of the test framework which sequence is "build, stage, test".

Done. Thanks!

devel/py-gitpython/Makefile
22

I knew about the "concurrent" feature but as I know (and use) very little about python, I was not sure if/when I should use or not.

Is it considered a good practice to add concurrent by default to python related ports?

24

I thought of that but I could not find a reference of the use of "build" in "regression-test:" or "do-test:" I kept it.

This revision was automatically updated to reflect the committed changes.