- update to 2.1.7 version
- switch to DISTVERSION
Details
- Reviewers
tcberner sunpoet - Commits
- rP452730: Update to 2.1.7
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Upstream is confused about devel/py-gitdb requirement: setup.py require "devel/py-gitdb2" but in requirements.txt tell "devel/py-gitdb".
Based on the current (old) port, I assumed upstream requirements.txt is outdated, since the version required in that file is old and the same of the rather outdated currently available port..
Following they documentation about test requirements, yes: https://github.com/gitpython-developers/GitPython/blob/master/test-requirements.txt
A closer look in the setup.py and it seems flake8 nor coverage are actually not necessary.
devel/py-gitpython/Makefile | ||
---|---|---|
21 ↗ | (On Diff #33774) | It's good to add USE_PYTHON=concurrent which allows installing this port with different python versions at the same time. |
24 ↗ | (On Diff #33708) | Sorry for not being clear enough. |
Done. Thanks!
devel/py-gitpython/Makefile | ||
---|---|---|
21 ↗ | (On Diff #33774) | I knew about the "concurrent" feature but as I know (and use) very little about python, I was not sure if/when I should use or not. Is it considered a good practice to add concurrent by default to python related ports? |
24 ↗ | (On Diff #33708) | I thought of that but I could not find a reference of the use of "build" in "regression-test:" or "do-test:" I kept it. |