Page MenuHomeFreeBSD

ifnet(9): split ifc_alloc_unit() (should make code a bit cleaner).
ClosedPublic

Authored by avos on Sep 30 2017, 9:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 12:23 PM
Unknown Object (File)
Mar 18 2024, 9:13 PM
Unknown Object (File)
Feb 8 2024, 11:01 AM
Unknown Object (File)
Jan 13 2024, 2:56 AM
Unknown Object (File)
Dec 22 2023, 11:31 PM
Unknown Object (File)
Nov 24 2023, 2:10 PM
Unknown Object (File)
Oct 29 2023, 2:21 AM
Unknown Object (File)
Oct 5 2023, 5:25 AM
Subscribers

Details

Summary

Allocate smallest unit number from pool from ifc_alloc_unit_next() and exact unit number (if available) from ifc_alloc_unit_specific().

While here, fix potential endless loop (*unit < 0 -> alloc_unr() succeeds but ifunit() fails -> (*unit)++ and then alloc_unr_specific() fails ->(*unit) is overridden with return result (-1) and then used instead of previous unit number).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Yes (but without reassigning *unit - it will not change after alloc_unr_specific() anyway).

Can you please grab the PR? :)

This revision was automatically updated to reflect the committed changes.