ifnet(9): split ifc_alloc_unit() (should make code a bit cleaner).
ClosedPublic
Actions

Authored by avos on Sep 30 2017, 9:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 24, 11:28 PM

	Unknown Object (File)
	Thu, Sep 17, 7:44 PM

	Unknown Object (File)
	Tue, Sep 8, 3:08 AM

	Unknown Object (File)
	Tue, Sep 8, 3:08 AM

	Unknown Object (File)
	Tue, Sep 8, 3:07 AM

	Unknown Object (File)
	Wed, Sep 2, 7:51 AM

	Unknown Object (File)
	Aug 28 2026, 5:02 AM

	Unknown Object (File)
	Aug 20 2026, 4:20 PM

View All Files

Subscribers

imp

Details

Reviewers

glebius

Group Reviewers

network

Commits

rS324813: MFC r324672:
rS324812: MFC r324672:
rS324672: ifnet(9): split ifc_alloc_unit() (should simplify code flow)

Summary

Allocate smallest unit number from pool from ifc_alloc_unit_next() and exact unit number (if available) from ifc_alloc_unit_specific().

While here, fix potential endless loop (*unit < 0 -> alloc_unr() succeeds but ifunit() fails -> (*unit)++ and then alloc_unr_specific() fails ->(*unit) is overridden with return result (-1) and then used instead of previous unit number).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos created this revision.Sep 30 2017, 9:27 PM

Herald added subscribers: ae, imp. · View Herald TranscriptSep 30 2017, 9:27 PM

Does this fix this bug? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217401

Yes (but without reassigning *unit - it will not change after alloc_unr_specific() anyway).

Can you please grab the PR? :)

Closed by commit rS324672: ifnet(9): split ifc_alloc_unit() (should simplify code flow) (authored by avos). · Explain WhyOct 16 2017, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if_clone.c

60 lines

Diff 34037

View Options

ifnet(9): split ifc_alloc_unit() (should make code a bit cleaner).ClosedPublicActions