Page MenuHomeFreeBSD
Differential D12529

Add flang as a non-default USES=fortran argument
ClosedPublic
Actions

Authored by jrm on Sep 28 2017, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 4, 9:13 PM
Unknown Object (File)
Mon, Aug 4, 8:02 AM
Unknown Object (File)
Sun, Jul 27, 5:17 AM
Unknown Object (File)
Sat, Jul 26, 9:35 PM
Unknown Object (File)
Sat, Jul 26, 2:06 PM
Unknown Object (File)
Wed, Jul 23, 6:01 PM
Unknown Object (File)
Tue, Jul 22, 3:25 PM
Unknown Object (File)
Fri, Jul 11, 7:37 PM
View All Files
Subscribers
db
gerald
jmd
mat
rene
swills

Details

Reviewers
jmd
db
swills
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Commits
rP452811: Mk/Uses/fortran.mk: Add flang as a non-default USES=fortran argument. Note,
Summary

Also see: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220313

Test Plan

I tested math/R with USES=fortran:flang and it builds/runs with no known errors. I do not (currently) have the resources to test all 139 ports with USES=fortran with USES=fortran:flang. Should we do something like a modified exp-run?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11795
Build 12139: arc lint + arc unit

Event Timeline

jrm created this revision.Sep 28 2017, 12:50 PM
Owners added a reviewer: O5: Ports Framework.Sep 28 2017, 12:50 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 28 2017, 12:50 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B11795: Diff 33529.Sep 28 2017, 12:50 PM
jrm edited the summary of this revision. (Show Details)Sep 28 2017, 1:16 PM
jrm updated this revision to Diff 33531.Sep 28 2017, 2:39 PM

Do not repeat USE_BINUTILS=yes

Harbormaster completed remote builds in B11797: Diff 33531.Sep 28 2017, 2:39 PM
jrm added subscribers: jmd, db.Sep 28 2017, 3:04 PM
jmd accepted this revision.Sep 28 2017, 3:35 PM

Looks great!

mat added inline comments.Oct 6 2017, 10:38 AM
Mk/Uses/fortran.mk
7

add a comma.

jrm updated this revision to Diff 33742.Oct 6 2017, 11:07 AM

Add a comma in Valid ARGS list

jrm marked an inline comment as done.Oct 6 2017, 11:07 AM
mat added a reviewer: gerald.Oct 6 2017, 3:59 PM
mat added a subscriber: gerald.

I think you should also ask for poeple on fortran@ to review this. I know @gerald is there, I do not know anybody else.

jrm added a reviewer: db.Oct 13 2017, 6:00 PM
db added a comment.Oct 24 2017, 4:35 PM

It looks fine to me! Please add!

swills accepted this revision.Oct 24 2017, 5:54 PM
swills added a subscriber: swills.

Yeah, let's do it.

rene removed a reviewer: gerald.Oct 24 2017, 6:18 PM
rene added a subscriber: rene.

Removing gerald@, db@ already approved it with her fortran hat.

This revision is now accepted and ready to land.Oct 24 2017, 6:18 PM
Closed by commit rP452811: Mk/Uses/fortran.mk: Add flang as a non-default USES=fortran argument. Note, (authored by jrm). · Explain WhyOct 24 2017, 7:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
15 lines

Diff 33529

View Options

Mk/Uses/fortran.mk

Loading...