Paths

Table of Contentst

Differential D12508

Update graphics/krita to 3.3.0
ClosedPublic
Actions

Authored by tcberner on Sep 26 2017, 3:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 30, 6:51 AM

	Unknown Object (File)
	Thu, Nov 28, 2:54 PM

	Unknown Object (File)
	Thu, Nov 28, 12:41 PM

	Unknown Object (File)
	Thu, Nov 28, 12:41 PM

	Unknown Object (File)
	Thu, Nov 28, 12:41 PM

	Unknown Object (File)
	Thu, Nov 28, 12:37 PM

	Unknown Object (File)
	Thu, Nov 28, 12:37 PM

	Unknown Object (File)
	Thu, Nov 28, 10:49 AM

View All 83 Files

Subscribers

Details

Reviewers

rakuco
adridg

Group Reviewers

Commits

rP461340: Update graphics/krita to 3.3.3

Summary

https://krita.org/en/item/krita-3-3-0-first-release-candidate/

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tcberner created this revision.Sep 26 2017, 3:16 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 26 2017, 3:16 PM

Harbormaster completed remote builds in B11762: Diff 33452.Sep 26 2017, 3:16 PM

mat added inline comments.Sep 26 2017, 3:59 PM

graphics/krita/Makefile
44 ↗	(On Diff #33452)	Why `+=` ?

Use = instead of +=.

Harbormaster completed remote builds in B11766: Diff 33458.Sep 26 2017, 4:09 PM

Don't you need to handle the G'MIC changes announced in https://krita.org/en/release-notes-for-krita-3-2/ (i.e. port and depend on gmic-qt)?

You're right, I should probalby add a port for https://github.com/c-koi/gmic-qt ... brb ^^

tcberner mentioned this in D12549: New port: graphics/gmic-qt.Sep 30 2017, 10:01 AM

Now Depends on D12549

Harbormaster completed remote builds in B11826: Diff 33583.Sep 30 2017, 10:07 AM

tcberner added a parent revision: D12549: New port: graphics/gmic-qt.Sep 30 2017, 10:08 AM

On 10.3/10.4, Krita crashes on exit, and it doesn't find gmic-qt so all of the filters are switched off. If I start gmic_qt_krita by hand it tells me *Could not connect to the Krita instance.

So it looks like some of the integration isn't entirely there yet.

In D12508#261363, @adridg wrote:

On 10.3/10.4, Krita crashes on exit, and it doesn't find gmic-qt so all of the filters are switched off. If I start gmic_qt_krita by hand it tells me *Could not connect to the Krita instance.

So it looks like some of the integration isn't entirely there yet.

You have to open an image so that the filters are available. -- the crash, I have too. gmic_qt_krita is supposed to be run from krita, not standalone, that's why you get that message :)

There's a 3.3.1 out by now.

adridg mentioned this in D13050: Update graphics/gmic-qt to 215.Nov 17 2017, 8:02 PM

LGTM. Suggest we commit this, wait for fallout from use of gmic-qt, then bump to 3.3.1.

This revision is now accepted and ready to land.Nov 19 2017, 9:42 PM

Please re-do for 3.3.3, once step0 has landed.

This revision now requires changes to proceed.Feb 8 2018, 2:51 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 9 2018, 9:04 PM

Closed by commit rP461340: Update graphics/krita to 3.3.3 (authored by tcberner). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

graphics/

krita/

20 lines

6 lines

files/

patch-git_2f59d0d1

22 lines

patch-plugins_extensions_CMakeLists.txt

13 lines

26 lines

Diff 39112

head/graphics/krita/Makefile

Loading...

head/graphics/krita/distinfo

Loading...

head/graphics/krita/files/patch-git_2f59d0d1

Loading...

head/graphics/krita/files/patch-plugins_extensions_CMakeLists.txt

Loading...

head/graphics/krita/pkg-plist

Loading...