multimedia/qt5-multimedia: Modernize and turn on sound support by default

[jrm]

Summary

I submitted this in response to a request from Adrian Chadd on #bsdports on EFnet.

<adrian> I got bitten again by qt5-multimedia not choosing an audi oside
<adrian> (alsa or pulseaudio)
<adrian> can we please pick one already pretty please?
<adrian> not having audio in a lot of qt5 based things is very sad :(
<adrian> preeeeeeeeeeeettty please?

I am not a user of multimedia/qt5-multimedia, but I tested www/otter-browser, which depends on it, and I had no sound issues with the default options of multimedia/qt5-multimedia. Adrian, could you elaborate on what kind of problems you see with the default options? Assuming some dependencies have broken sound with the current default options, I copied the approach used by www/firefox and turned on both audio options by default. I think this will make life easier for the average user and users that do not want one or both of the audio options could build their own package. In any case, I will wait to confirm the details of the current issue before proceeding.

Test Plan

portlint -C: warnings about missing license
poudriere testport 10/11 i386/amd64: OK

[jrm]

Sort entries in OPTIONS_DEFAULT

[tcberner]

multimedia/qt5-multimedia/Makefile

25 ↗

(On Diff #33366)

I'm not sure if PULSEAUDIO goes under sensible default -- ALSA why not.

[adrian]

hi! thanks for this! this will be really useful!

[tcberner]

I wont accept this without some discussion in why pulse needs to be default.

[adrian]

I think alsa is fine, as pulseaudio can capture alsa sound too.

[jrm]

Do not turn on pulseaudio knob by default

[tcberner]

multimedia/qt5-multimedia/Makefile

12 ↗

(On Diff #33870)

I don't think this is necessary. You waste the line we saved by setting it there =)

[jrm]

multimedia/qt5-multimedia/Makefile

12 ↗

(On Diff #33870)

It 1. prevents portlint from reporting several errors and 2. let's others know of this somewhat unusual situation with the license set elsewhere, so they do not waste time searching for license information to set it in the Makefile. I think this is worth a one-line comment.

[rakuco]

I'm fine as long as @tcberner is fine :)

[tcberner]

Thanks for working on this :)