Page MenuHomeFreeBSD
Differential D12436

Improved logging of gtaskqueue failues
ClosedPublic
Actions

Authored by shurd on Sep 21 2017, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 5:53 AM
Unknown Object (File)
Nov 18 2024, 11:48 PM
Unknown Object (File)
Nov 9 2024, 10:15 PM
Unknown Object (File)
Nov 4 2024, 2:20 PM
Unknown Object (File)
Oct 11 2024, 8:27 AM
Unknown Object (File)
Oct 9 2024, 9:08 AM
Unknown Object (File)
Sep 26 2024, 8:54 PM
Unknown Object (File)
Sep 12 2024, 6:21 PM
View All 66 Files
Subscribers
bhargava.marreddy_broadcom.com
imp

Details

Reviewers
sbruno
Commits
rS323879: Improved logging of gtaskqueue failues
Summary

Check the return code of intr_setaffinity() and log any errors
it returns. When a qid is not located, log an error before returning
failure.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shurd created this revision.Sep 21 2017, 6:43 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 21 2017, 6:43 PM
Harbormaster completed remote builds in B11655: Diff 33271.Sep 21 2017, 6:43 PM
sbruno requested changes to this revision.Sep 21 2017, 7:51 PM
sbruno added inline comments.
sys/kern/subr_gtaskqueue.c
793 ↗(On Diff #33271)

pedantic nit. Do you want to explicitly put the function name in the printf() calls here or should we use func ?

Basically, all these printf() calls should be one way or the other.

This revision now requires changes to proceed.Sep 21 2017, 7:51 PM
shurd updated this revision to Diff 33276.Sep 21 2017, 7:59 PM

Use func for all messages

Harbormaster completed remote builds in B11660: Diff 33276.Sep 21 2017, 7:59 PM
shurd marked an inline comment as done.Sep 21 2017, 8:00 PM
sbruno accepted this revision.Sep 21 2017, 9:00 PM
This revision is now accepted and ready to land.Sep 21 2017, 9:00 PM
Closed by commit rS323879: Improved logging of gtaskqueue failues (authored by shurd). · Explain WhySep 21 2017, 9:15 PM
This revision was automatically updated to reflect the committed changes.
bhargava.marreddy_broadcom.com added a subscriber: bhargava.marreddy_broadcom.com.Sep 25 2017, 1:53 PM

Hi Stephen,

Just wanted to mention that this patch is causing warning messages with bnxt driver during load.
If there is any thing missing in bnxt driver, we will implement. kindly let me know.

bnxt0: using 12 rx queues 12 tx queues
bnxt0: Using MSIX interrupts with 13 vectors
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach_cpu: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
taskqgroup_attach: setaffinity failed: 3
bnxt0: Ethernet address: 00:0a:f7:c4:b2:c0

Thanks,
Chenna.

shurd added a comment.Sep 25 2017, 5:22 PM
In D12436#258905, @bhargava.marreddy_broadcom.com wrote:

Hi Stephen,

Just wanted to mention that this patch is causing warning messages with bnxt driver during load.
If there is any thing missing in bnxt driver, we will implement. kindly let me know.

bnxt0: using 12 rx queues 12 tx queues
bnxt0: Using MSIX interrupts with 13 vectors
taskqgroup_attach_cpu: setaffinity failed: 3
...
taskqgroup_attach: setaffinity failed: 3
...
bnxt0: Ethernet address: 00:0a:f7:c4:b2:c0

I should have a patch that fixes these issues today or tomorrow. It appears the rid parameter does not actually expect an rid.

Thanks for the heads-up.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
38 lines

Diff 33283

View Options

head/sys/kern/subr_gtaskqueue.c

Loading...