Fix kvm_getprocs(3) error reporting in ps(1).
ClosedPublic
Actions

Authored by trasz on Sep 19 2017, 2:14 PM.

Details

Reviewers

cem
jhb

Commits

rS324367: Fix kvm_getprocs(3) error reporting in ps(1).

Summary

Previously it just didn't work at all - kvm_getprocs(3) doesn'tupdate the &nentries when it returns NULL. I'm not sure where the previous logic come from, or what it was supposed to do.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11631
Build 11977: arc lint + arc unit

Event Timeline

trasz created this revision.Sep 19 2017, 2:14 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 19 2017, 2:14 PM

trasz added reviewers: cem, jhb.Sep 19 2017, 2:16 PM

trasz retitled this revision from Fix kvm_getprocs(3) error reporting in ps(1). Previously it just didn't work at all - kvm_getprocs(3) doesn't update the &nentries when it returns NULL. to Fix kvm_getprocs(3) error reporting in ps(1)..

trasz edited the summary of this revision. (Show Details)

Note that 'ps -p <X>' is supposed to only output the header and not fail it seems, so you need to ensure you aren't breaking that. See rS127513 and rS127149 which added the nentries check and explain why. (svn annotate is your friend, there was only one "noise" change of s/0/NULL/ to skip over to find these two commits for the line you are changing)