lang/php72: Simplify with options framework - Convert all PORT_OPTIONS:M checks to OPT_something - Order alphabetically where possible - Fold double PHP_MODNAME checks into one
|79 ↗||(On Diff #33204)|
No such thing as USES=apache. It is always better to not mix 50 different kind of changes in a patch. Especially in case of a new USES where the old usage is not removed and would probably be better off being done in batch.
Also note that 2.2+ is irrelevant, the only versions we have are 2.2 and 2.4, and 2.2 is deprecated so it will soon be 2.4 only.
|157 ↗||(On Diff #33204)|
Makefile.ext does not .include <bsd.port.mk> put it back at the end.
OPT_* before bsd.port.pre.mk
Turns out the include of apache.mk is not needed at all.
It seems to have been there so APXS is defined, this is no longer
a requirement. Include moves down to just before where options
Additionally for Makefile.ext:
- Remove _DESC that are in Mk/bsd.options.desc.mk
- Fix faulty REGEX_REGEX_*
i'm very sorry that this ticket is stuck. Since i will be away for some time, i took a short, but not too deep, look at it. It will need an rebase, but i can't see any showstopper or obvious issues. So: please go ahead and big thank you for your work and patience!