Page MenuHomeFreeBSD
Differential D12320

x86 MCA: Extract CMCI support predicate into function
ClosedPublic
Actions

Authored by cem on Sep 11 2017, 4:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 23, 9:30 PM
Unknown Object (File)
Sat, Aug 22, 3:22 PM
Unknown Object (File)
Sat, Aug 22, 3:19 PM
Unknown Object (File)
Sat, Aug 22, 11:52 AM
Unknown Object (File)
Fri, Aug 21, 3:22 PM
Unknown Object (File)
Wed, Aug 12, 1:16 PM
Unknown Object (File)
Wed, Aug 12, 1:13 PM
Unknown Object (File)
Wed, Aug 12, 1:12 PM
View All Files
Subscribers
None

Details

Reviewers
avg
kib
jhb
markj
Commits
rS323462: x86 MCA: Extract CMCI support predicate into function
Summary

On AMD, the MCG_CAP feature bit is reserved -- not explicitly zero. Do not
use it to determine CMCI support.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem created this revision.Sep 11 2017, 4:23 PM
Harbormaster completed remote builds in B11493: Diff 32921.Sep 11 2017, 4:23 PM
markj added inline comments.Sep 11 2017, 5:50 PM
sys/x86/x86/mca.c
337 ↗(On Diff #32921)

This won't compile if DEV_APIC isn't defined.

cem updated this revision to Diff 32929.Sep 11 2017, 6:01 PM
cem marked an inline comment as done.

Fix build on !DEV_APIC

markj accepted this revision.Sep 11 2017, 6:07 PM
This revision is now accepted and ready to land.Sep 11 2017, 6:07 PM
avg accepted this revision.Sep 11 2017, 8:08 PM

LGTM

Closed by commit rS323462: x86 MCA: Extract CMCI support predicate into function (authored by cem). · Explain WhySep 11 2017, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
x86/
x86/
18 lines

Diff 32936

View Options

head/sys/x86/x86/mca.c

Loading...