[NEW PORT] audio/py-opuslib: Python bindings to the libopus, IETF low-delay audio codec
ClosedPublic
Actions

Authored by ultima on Sep 10 2017, 9:49 PM.

Details

Reviewers

lifanov
matthew
koobs

Commits

rP449820: Python bindings to the libopus, IETF low-delay audio codec.

Summary

Python bindings to the libopus, IETF low-delay audio codec.

WWW: https://github.com/onbeep/opuslib

PR\: 222038
Submitted by\: Yuri Victorovich (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
looks fine.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ultima created this revision.Sep 10 2017, 9:49 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 10 2017, 9:49 PM

Harbormaster completed remote builds in B11480: Diff 32903.Sep 10 2017, 9:49 PM

ultima mentioned this in D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger.Sep 10 2017, 10:03 PM

ultima added a subscriber: Python.Sep 10 2017, 10:04 PM

koobs requested changes to this revision.Sep 11 2017, 5:44 AM

koobs added a subscriber: koobs.

koobs added inline comments.

audio/py-opuslib/Makefile
20 ↗	(On Diff #32903)	setup.py contains a `test_suite` entry, so adding a test target to run unit tests is trivial, and should be added where tests are provided in the source distribution (ask upstream to include them if they're not) do-test: @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test

This revision now requires changes to proceed.Sep 11 2017, 5:44 AM

New port needs entries in the Category Makefile. Other than that, and Koob's comment this is fine.

In D12309#255480, @matthew wrote:

New port needs entries in the Category Makefile. Other than that, and Koob's comment this is fine.

I was planning on using the Tools/scripts/addport script to add the port which automatically adds this bit. Is this acceptable or does it require to be in the Phabricator differential?

ultima added inline comments.Sep 11 2017, 7:04 AM

audio/py-opuslib/Makefile
20 ↗	(On Diff #32903)	Although there is a test_suite, the reason it is not in the port is due to not being provided by CHEESESHOP src like it does in github and will throw error: ImportError: No module named tests

koobs added a child revision: D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger.Sep 11 2017, 12:57 PM

@ultima Thanks for clarifying. Not a blocker for commit, but ask upstream (or ask maintainer to ask upstream) to add tests/test files to the source distribution. This usually takes the form of adding entries to MANIFEST.in to include the files/dirs.

This revision is now accepted and ready to land.Sep 11 2017, 1:06 PM

Approved, obviously pending SUBDIR addition to category/Makefile

lgtm