[NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger

[ultima]

Summary

unMessage is a peer-to-peer instant messaging application designed to enhance
privacy and anonymity.

Features:

• Transport makes use of Twisted, Tor Onion Services and txtorcon
• Encryption is performed using the Double Ratchet Algorithm implemented in pyaxo (using PyNaCl)
• Authentication makes use of the Socialist Millionaire Protocol implemented in Cryptully
• Transport metadata is minimized by Tor and application metadata by the unMessage protocol
• User interfaces are created with Tkinter (graphical) and curses (command-line)

WWW: https://github.com/AnemoneLabs/unmessage

PR\: 222043
Submitted by\: Yuri Victorovich (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: no port directory /usr/ports/audio/py-opuslib found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/security/py-pyaxo found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/security/py-txtorcon found, even though it is listed in RUN_DEPENDS.
0 fatal errors and 3 warnings found.

Wont be committed till after D12309 D12310 and D12311 which will resolve these.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[koobs]

Missing SUBDIR addition to category/Makefile in changeset

[matthew]

New port needs entries in the category Makefile. Other than that, this looks fine.

[ultima]

In D12312#255476, @koobs wrote:

Missing SUBDIR addition to category/Makefile in changeset

In D12312#255482, @matthew wrote:

New port needs entries in the category Makefile. Other than that, this looks fine.

I was planning on using the Tools/scripts/addport script to add the port which automatically adds this bit. Is this acceptable or does it require to be in the Phabricator differential?

[koobs]

In D12312#255485, @ultima wrote:

In D12312#255476, @koobs wrote:

Missing SUBDIR addition to category/Makefile in changeset

In D12312#255482, @matthew wrote:

New port needs entries in the category Makefile. Other than that, this looks fine.

I was planning on using the Tools/scripts/addport script to add the port which automatically adds this bit. Is this acceptable or does it require to be in the Phabricator differential?

I (personally) prefer to see it in reviews, as reviewers assume nothing and cant know that it wasn't just accidentally forgotten, which goes for anything else.

[matthew]

In D12312#255543, @koobs wrote:

In D12312#255485, @ultima wrote:

In D12312#255476, @koobs wrote:

Missing SUBDIR addition to category/Makefile in changeset

In D12312#255482, @matthew wrote:

New port needs entries in the category Makefile. Other than that, this looks fine.

I was planning on using the Tools/scripts/addport script to add the port which automatically adds this bit. Is this acceptable or does it require to be in the Phabricator differential?

I (personally) prefer to see it in reviews, as reviewers assume nothing and cant know that it wasn't just accidentally forgotten, which goes for anything else.

Using the addport script is definitely the way to go. I'm happy for you to add this port that way without needing to see a diff of the changes to the category Makefile. However, as @koobs said: if it wasn't mentioned in the review, then the reviewers have no way of knowing if you had actually forgotten about that part, or not.

[lifanov]

I'm good with this revision. Make sure you commit the dependencies in order or at the same time so that the tree is consistent.

[lifanov]

I personally prefer to see the entire change, including the category file update, but I don't feel strongly about it.