Page MenuHomeFreeBSD

Remove spaces from CTL devices' default serial numbers
ClosedPublic

Authored by asomers on Sep 6 2017, 9:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 4, 6:09 PM
Unknown Object (File)
Nov 7 2024, 3:52 PM
Unknown Object (File)
Oct 15 2024, 7:55 AM
Unknown Object (File)
Oct 14 2024, 1:37 PM
Unknown Object (File)
Sep 19 2024, 6:25 PM
Unknown Object (File)
Sep 19 2024, 3:08 PM
Unknown Object (File)
Sep 19 2024, 5:16 AM
Unknown Object (File)
Sep 18 2024, 11:14 AM
Subscribers

Details

Summary

Remove spaces from CTL devices' default serial numbers

It's awkward to have spaces in CAM device serial numbers. That leads to
such things as device nodes named "/dev/diskid/MYSERIAL%20%20%201". Better
to replace the spaces with "0"s. This change only affects the default
serial numbers for users who don't provide their own.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me, thanks!

This revision is now accepted and ready to land.Sep 7 2017, 8:22 PM

I have no objections against the change. Though the whole concept of using so simple and repeatable LUN IDs is a request for troubles caused by conflicts.

This revision was automatically updated to reflect the committed changes.