Page MenuHomeFreeBSD

Remove spaces from CTL devices' default serial numbers
ClosedPublic

Authored by asomers on Sep 6 2017, 9:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 10:28 AM
Unknown Object (File)
May 22 2024, 2:55 PM
Unknown Object (File)
May 22 2024, 4:17 AM
Unknown Object (File)
May 22 2024, 3:51 AM
Unknown Object (File)
May 21 2024, 9:23 PM
Unknown Object (File)
Apr 28 2024, 8:34 AM
Unknown Object (File)
Mar 3 2024, 2:40 PM
Unknown Object (File)
Jan 12 2024, 3:17 PM
Subscribers

Details

Summary

Remove spaces from CTL devices' default serial numbers

It's awkward to have spaces in CAM device serial numbers. That leads to
such things as device nodes named "/dev/diskid/MYSERIAL%20%20%201". Better
to replace the spaces with "0"s. This change only affects the default
serial numbers for users who don't provide their own.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good to me, thanks!

This revision is now accepted and ready to land.Sep 7 2017, 8:22 PM

I have no objections against the change. Though the whole concept of using so simple and repeatable LUN IDs is a request for troubles caused by conflicts.

This revision was automatically updated to reflect the committed changes.