Page MenuHomeFreeBSD
Differential D12221

Skylake server core PMC support for hwpmc(4)
ClosedPublic
Actions

Authored by kib on Sep 3 2017, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 12:49 PM
Unknown Object (File)
Mon, Nov 3, 1:48 AM
Unknown Object (File)
Sat, Nov 1, 6:44 PM
Unknown Object (File)
Sun, Oct 26, 9:58 AM
Unknown Object (File)
Sat, Oct 25, 7:47 PM
Unknown Object (File)
Sat, Oct 25, 7:46 PM
Unknown Object (File)
Sat, Oct 25, 7:46 PM
Unknown Object (File)
Sat, Oct 25, 7:46 PM
View All 85 Files
Subscribers
emaste
gnn
imp

Details

Reviewers
rstone
Commits
rS323230: Skylake server core PMC support for hwpmc(4).
Test Plan

This version passes pmctest.py.

I also looked at some most interesting counters like machine restarts with pmcstat in top mode, which also look reasonable.

Tested on Intel(R) Xeon(R) Platinum 8170 CPU

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Sep 3 2017, 3:22 PM
Herald added subscribers: gnn, imp. · View Herald TranscriptSep 3 2017, 3:22 PM
kib updated this revision to Diff 32625.Sep 3 2017, 3:56 PM
kib edited the test plan for this revision. (Show Details)
kib edited the test plan for this revision. (Show Details)Sep 3 2017, 3:59 PM
kib added a reviewer: rstone.
emaste added a comment.Sep 5 2017, 8:17 PM

Without comparing entries against documentation this looks reasonable to my eye.

Closed by commit rS323230: Skylake server core PMC support for hwpmc(4). (authored by kib). · Explain WhySep 6 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libpmc/
24 lines
sys/
dev/
hwpmc/
496 lines
6 lines
292 lines

Diff 32725

View Options

head/lib/libpmc/libpmc.c

Loading...
View Options

head/sys/dev/hwpmc/hwpmc_core.c

Loading...
View Options

head/sys/dev/hwpmc/hwpmc_intel.c

Loading...
View Options

head/sys/dev/hwpmc/pmc_events.h

Loading...