Page MenuHomeFreeBSD

devel/pear-TheSeer_DirectoryScanner: Update from 1.2.0 to 1.3.2
ClosedPublic

Authored by joneum on Aug 31 2017, 5:52 PM.

Details

Summary

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxx

Test Plan

~...devel/pear-TheSeer_DirectoryScanner: portlint -AC [19:48:35]
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere testport:

10.3-amd64
10.3-i386
11.1-amd64
11.1-i386
12.0-CURRENT r321899 amd64
12.0-CURRENT r321913 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm still confused about all your pear-Updates. At first: it removes the usage of pear. Okay, PEAR was gone and resurrected and many projects went away. Fine.
But:

  1. pear is still in the package name even if its not used
  2. When read correct (i'm unsure): you add the pear-channel as RUN/BUILD dependency for the script itself without using any pear-functionality at all?
  3. Downloading it plainly from GitHub and executing it and the test-cases is just fine So: why even bother with the depends?

That questions and confusions are true for the other reviews i took a look at it.

In D12189#255501, @tz wrote:

I'm still confused about all your pear-Updates. At first: it removes the usage of pear. Okay, PEAR was gone and resurrected and many projects went away. Fine.
But:

  1. pear is still in the package name even if its not used

Did you mean PKGNAMEPREFIX= pear-TheSeer_?

  1. When read correct (i'm unsure): you add the pear-channel as RUN/BUILD dependency for the script itself without using any pear-functionality at all?

pear.netpirates.net does not exist anymore. So I changed to pear-channel-theseer.

  1. Downloading it plainly from GitHub and executing it and the test-cases is just fine So: why even bother with the depends?

Well, you mean here, remove both BUILD_DEPENDS and RUN_DEPENDS and then test it?

That questions and confusions are true for the other reviews i took a look at it.

Then I'm on nothing more committen until the problem is solved to your full satisfaction.

So no future feedback I approved this.

This revision is now accepted and ready to land.Sep 18 2017, 9:47 AM
This revision was automatically updated to reflect the committed changes.