mlx4_en: Implement SIOCGIFRSS{KEY,HASH}

[gallatin]

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

1905 ↗

(On Diff #32537)

Why the ifdefs?

[sepherosa_gmail.com]

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

1905 ↗

(On Diff #32537)

I was not so sure whether I could MFC D12174 to 10-stable/11-stable or not, but I definitely want to MFC driver bits to 10-stable/11-stable.

If D12174 goes well, I probably will MFC it to 10-stable/11-stable. I think adding IOCs does not break ABI.

[• hselasky]

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

2041 ↗

(On Diff #32537)

Hi,

Please add a "length" argument to rss_key and optimise away the intermediate "key" storage.

--HPS

sys/dev/mlx4/mlx4_en/mlx4_en_rx.c

821 ↗

(On Diff #32537)

BSD-style: 4-space indent after wrap.

846 ↗

(On Diff #32537)

Can you optimise away this temporary storage?

[sepherosa_gmail.com]

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

2041 ↗

(On Diff #32537)

Toeplitz key size is pretty standard. But, sure, I could add a length parameter.

As about optimizing away the key, it's fine w/ me; though I will have to say both code you mentioned is not on hot path.

sys/dev/mlx4/mlx4_en/mlx4_en_rx.c

821 ↗

(On Diff #32537)

Heh, OK. This is verbatim copy of the original code.

846 ↗

(On Diff #32537)

Sure.

[sepherosa_gmail.com]

Address Hans' comment

[• hselasky]

Thank you. Currently reviewing this patch in Mellanox.

[• hselasky]

With some modifications.