Differential D12098

During VLAN creation, bnxt_init() seems to be getting invoked without bnxt_stop().
ClosedPublic
Actions

Authored by bhargava.marreddy_broadcom.com on Aug 21 2017, 3:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 4, 1:45 AM

	Unknown Object (File)
	Mon, Aug 3, 8:23 AM

	Unknown Object (File)
	Sun, Aug 2, 4:43 AM

	Unknown Object (File)
	Sat, Aug 1, 6:40 PM

	Unknown Object (File)
	Thu, Jul 30, 7:25 AM

	Unknown Object (File)
	Tue, Jul 28, 7:33 AM

	Unknown Object (File)
	Mon, Jul 27, 10:44 PM

	Unknown Object (File)
	Tue, Jul 21, 5:25 AM

View All Files

Subscribers

imp

Contributor Reviews (src)

Details

Reviewers

shurd
sbruno
venkatkumar.duvvuru_broadcom.com
siva.kallam_broadcom.com

Commits

rS322823: iflib: call device's if_init function during vlan initialization.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bhargava.marreddy_broadcom.com created this revision.Aug 21 2017, 3:01 PM

Herald added a reviewer: shurd. · View Herald TranscriptAug 21 2017, 3:01 PM

Herald added subscribers: Contributor Reviews (src), ae, imp. · View Herald Transcript

Shouldn't I expect bnxt_stop() before bnxt_init() during VLAN creation? Please correct me if I'm missing anything here,

Looks like a good catch.

This revision is now accepted and ready to land.Aug 21 2017, 4:48 PM

bhargava.marreddy_broadcom.com added a reviewer: siva.kallam_broadcom.com.Aug 23 2017, 12:57 PM

Closed by commit rS322823: iflib: call device's if_init function during vlan initialization. (authored by sbruno). · Explain WhyAug 23 2017, 9:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

iflib.c

4 lines

Diff 32349

View Options

During VLAN creation, bnxt_init() seems to be getting invoked without bnxt_stop().ClosedPublicActions