Add xx_NEW flag to mtx(9), sx(9), rmlock(9) and rwlock(9). A xx_NEW flag passed to xx_init_flags() to avoid check for double-init. Use MTX_NEW in cpu_init_clocks_bsp() when initializing PCPU timerstate mtx.
ClosedPublic
Actions

Authored by dchagin on Nov 22 2014, 11:05 AM.

Details

Reviewers

jhb
mav

Group Reviewers

manpages

Commits

rS275751: Add _NEW flag to mtx(9), sx(9), rmlock(9) and rwlock(9).

Summary

I'll change man pages if the proposal would be approved.

Test Plan

fixex panic et_hw_mtx already initialized.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dchagin updated this revision to Diff 2506.Nov 22 2014, 11:05 AM

dchagin retitled this revision from to Add xx_NEW flag to mtx(9), sx(9), rmlock(9) and rwlock(9). A xx_NEW flag passed to xx_init_flags() to avoid check for double-init. Use MTX_NEW in cpu_init_clocks_bsp() when initializing PCPU timerstate mtx..

dchagin edited the test plan for this revision. (Show Details)

dchagin added reviewers: mav, jhb.

dchagin updated this object.

Normally this is fixed by zero'ing the memory in question. That said, I've wanted a MTX_NEW for quite a while anyway. Please add the _NEW flags (along with man page updates) as a standalone commit from adding uses of them.

Fixed.

Man pages changed, usage of MTX_NEW removed from patch.

dchagin added a reviewer: manpages.Nov 26 2014, 9:06 PM

The second and third man page changes are identical and the comments apply to them as well.

share/man/man9/mutex.9
180 ↗	(On Diff #2550)	s/kernel compiled/kernel has been compiled/
185 ↗	(On Diff #2550)	Sorry, this does not make sense. Is it supposed to be: has not been initialized multiple times without intervening calls to
187 ↗	(On Diff #2550)	s/unless/unless the/