Page MenuHomeFreeBSD
Differential D11928

i386/boot2: -fno-asynchronous-unwind-tables for gcc
ClosedPublic
Actions

Authored by rlibby on Aug 9 2017, 12:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 6:32 AM
Unknown Object (File)
Nov 19 2023, 2:25 AM
Unknown Object (File)
Nov 19 2023, 1:53 AM
Unknown Object (File)
Jul 1 2023, 11:18 PM
Unknown Object (File)
May 9 2023, 7:12 PM
Unknown Object (File)
Jan 2 2023, 5:06 PM
Subscribers
dim
jhb
markj

Details

Reviewers
imp
Commits
rS322329: i386/boot2: -fno-asynchronous-unwind-tables for gcc
Summary

The amd64 build of boot2 was failing with gcc 6.3.0 due to being more than 1 kB too large. It was apparently generating a .eh_frame section which was not being removed by objcopy -S. The .eh_frame section seems to be mandatory per the amd64 ABI, but boot2 is compiled for i386 (uses -m32), and therefore should be optional in this context. Suppress generation of .eh_frame with the -fno-asynchronous-unwind-tables flag to gcc. This saves 1348 bytes (the limit is 7680 bytes).

Test Plan

amd64/gcc buildworld

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby created this revision.Aug 9 2017, 12:17 AM
Harbormaster completed remote builds in B10960: Diff 31781.Aug 9 2017, 12:17 AM
dim added a comment.Aug 9 2017, 10:51 AM

LGTM.

imp accepted this revision.Aug 9 2017, 2:20 PM

Looks reasonable to me. This switch is supported in gcc 4.2 and newer so we don't need anything conditional.

This revision is now accepted and ready to land.Aug 9 2017, 2:20 PM
markj added a comment.Aug 9 2017, 4:08 PM

Approved

Closed by commit rS322329: i386/boot2: -fno-asynchronous-unwind-tables for gcc (authored by rlibby). · Explain WhyAug 9 2017, 8:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
i386/
boot2/
1 line

Diff 31831

View Options

head/sys/boot/i386/boot2/Makefile

Loading...