Page MenuHomeFreeBSD
Differential D11899

Update sysutils/filelight-kde4 to 17.04.3 and rename it in the process
ClosedPublic
Actions

Authored by tcberner on Aug 6 2017, 9:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 2:13 AM
Unknown Object (File)
Mon, May 6, 8:29 AM
Unknown Object (File)
Wed, May 1, 11:46 PM
Unknown Object (File)
Sun, Apr 28, 8:40 PM
Unknown Object (File)
Fri, Apr 19, 12:31 PM
Unknown Object (File)
Apr 4 2024, 3:00 PM
Unknown Object (File)
Apr 4 2024, 3:00 PM
Unknown Object (File)
Apr 4 2024, 3:00 PM
View All 62 Files
Subscribers
mat
rakuco

Details

Reviewers
adridg
yuri_rawbw.com
rakuco
Group Reviewers
kde
Commits
rP449946: Update sysutils/filelight-kde4 to 17.04.3 and rename it in the process
Summary
  • Update to the current version
  • Rename port
  • Use 17.04.3 rather than 16.12.3 (the one set by kde.mk) as the localization is only shipped as part of the tarballs since 17.04

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner created this revision.Aug 6 2017, 9:01 AM
Herald added a subscriber: mat. · View Herald TranscriptAug 6 2017, 9:01 AM
Harbormaster completed remote builds in B10898: Diff 31660.Aug 6 2017, 9:01 AM
tcberner added a comment.Aug 6 2017, 9:02 AM

Sorry, my ports tree interfered with the portversion...

tcberner updated this revision to Diff 31661.Aug 6 2017, 9:05 AM

Update distinfo to match kde.mk

tcberner updated this revision to Diff 31664.Aug 6 2017, 9:24 AM

Switch it to 17.04.3, as localization was still shipped inside kde-l10n tarballs in 16.xx.yy.

tcberner updated this revision to Diff 31665.Aug 6 2017, 9:48 AM

Make stage-qa happy, and fix plist to match 17.04.3.

Harbormaster completed remote builds in B10901: Diff 31665.Aug 6 2017, 9:48 AM
tcberner retitled this revision from Update sysutils/fileflight to Update sysutils/fileflight-kde4 to 17.04.3 and rename it in the process.Aug 6 2017, 9:49 AM
tcberner edited the summary of this revision. (Show Details)
rakuco accepted this revision.Aug 6 2017, 10:31 AM
rakuco added a subscriber: rakuco.

lgtm

MOVED
9466 ↗(On Diff #31665)

Unrelated.

This revision is now accepted and ready to land.Aug 6 2017, 10:31 AM
tcberner marked an inline comment as done.Aug 6 2017, 10:50 AM
tcberner added inline comments.
MOVED
9466 ↗(On Diff #31665)

I committed this separately.

tcberner retitled this revision from Update sysutils/fileflight-kde4 to 17.04.3 and rename it in the process to Update sysutils/filelight-kde4 to 17.04.3 and rename it in the process.Aug 6 2017, 11:57 AM
adridg accepted this revision.Aug 6 2017, 12:46 PM

Other than minor comments, LGTM.

MOVED
9502 ↗(On Diff #31665)

Shouldn't there be an ".. and updated to KF5" or "no longer KDE4-based" in the comment?

9502 ↗(On Diff #31665)

Simnilarly, what about an UPDATING entry, warning users that the underlying technology is replaced?

tcberner marked an inline comment as done.Aug 6 2017, 1:13 PM
In D11899#246695, @groot_kde.org wrote:

Other than minor comments, LGTM.

I think this is the same way we did it for the other ports we already updated.

Closed by commit rP449946: Update sysutils/filelight-kde4 to 17.04.3 and rename it in the process (authored by tcberner). · Explain WhySep 16 2017, 7:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
1 line
sysutils/
2 lines
filelight-kde4/
16 lines
2 lines
7 lines
21 lines
filelight/
26 lines
3 lines
7 lines
96 lines

Diff 33148

View Options

head/MOVED

Loading...
View Options

head/sysutils/Makefile

Loading...
View Options

head/sysutils/filelight-kde4/Makefile

Loading...
View Options

head/sysutils/filelight-kde4/distinfo

Loading...
View Options

head/sysutils/filelight-kde4/pkg-descr

Loading...
View Options

head/sysutils/filelight-kde4/pkg-plist

Loading...
View Options

head/sysutils/filelight/Makefile

Loading...
View Options

head/sysutils/filelight/distinfo

Loading...
View Options

head/sysutils/filelight/pkg-descr

Loading...
View Options

head/sysutils/filelight/pkg-plist

Loading...