Use nstosbt() instead of multiplying by SBT_1NS to avoid roundoff errors.
ClosedPublic
Actions

Authored by • ian on Jul 29 2017, 5:13 PM.

Details

Reviewers

avg
mav

Commits

rS324756: MFC r323985:
rS323985: Use nstosbt() instead of multiplying by SBT_1NS to avoid roundoff errors.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• ian created this revision.Jul 29 2017, 5:13 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptJul 29 2017, 5:13 PM

I didn't commit these along with the similar changes to the main source base because I didn't know if there were special considerations for cddl, such as needing to coordinate changes with upstream.

This is potentially a noticable behavior change, because of the use of C_ABSOLUTE in one of the calls. Absolute time in nanos calculated by multiplying with SBT_1NS could lead to seriously early wakeup from the sleep.

• ian mentioned this in D12355: MFV r323535: 8585 improve batching done in zil_commit().Sep 15 2017, 9:15 PM

Looks good to me.

This revision is now accepted and ready to land.Sep 18 2017, 2:00 AM

LGTM. Thanks!

Closed by commit rS323985: Use nstosbt() instead of multiplying by SBT_1NS to avoid roundoff errors. (authored by • ian). · Explain WhySep 25 2017, 3:03 PM

This revision was automatically updated to reflect the committed changes.