Similar to r315225, discard 768 RC4 bytestream (PR 217920)
ClosedPublic
Actions

Authored by cy on Jul 27 2017, 2:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 26 2024, 10:52 PM

	Unknown Object (File)
	Apr 26 2024, 10:52 PM

	Unknown Object (File)
	Apr 26 2024, 10:52 PM

	Unknown Object (File)
	Apr 26 2024, 8:54 PM

	Unknown Object (File)
	Apr 23 2024, 10:10 PM

	Unknown Object (File)
	Mar 11 2024, 1:21 PM

	Unknown Object (File)
	Mar 11 2024, 7:06 AM

	Unknown Object (File)
	Jan 15 2024, 7:59 PM

View All 14 Files

Subscribers

imp

Details

Reviewers

delphij
emaste
cem

Commits

rS322012: MFC r321605:
rS321605: As in r315225, discard 3072 bytes of RC4 bytestream instead of 1024.

Summary

r315225 adjusts libkern/arc4random.c to discard first 768 bytes of RC4 bytestream. PR 217920 points out that ipfilter has the same issue. Can you please review. (The libc adjustment RC4 adjustment is by 3072 bytes.)

Test Plan

This has already been committed in libc and libckern by r315225.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cy created this revision.Jul 27 2017, 2:09 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2017, 2:09 AM

cem accepted this revision.Jul 27 2017, 2:36 AM

This revision is now accepted and ready to land.Jul 27 2017, 2:36 AM

emaste accepted this revision.Jul 27 2017, 2:54 AM

Closed by commit rS321605: As in r315225, discard 3072 bytes of RC4 bytestream instead of 1024. (authored by cy). · Explain WhyJul 27 2017, 6:26 AM

This revision was automatically updated to reflect the committed changes.

cy mentioned this in rS321605: As in r315225, discard 3072 bytes of RC4 bytestream instead of 1024..

cy mentioned this in rS322012: MFC r321605:.Aug 3 2017, 2:23 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

ipfilter/

arc4random.c

4 lines

Diff 31247

View Options

head/contrib/ipfilter/arc4random.c

Similar to r315225, discard 768 RC4 bytestream (PR 217920)ClosedPublicActions