Include ARCH_FLAGS in CFLAGS when building modules.
ClosedPublic
Actions

Authored by brooks on Jul 18 2017, 12:39 AM.

Details

Reviewers

imp
jhb
emaste

Commits

rS324643: MFC r321256:
rS324642: MFC r321256:
rS321256: Include ARCH_FLAGS in CFLAGS when building modules.

Summary

Without this change, modules will match the default compiler configuration
which may not be the same as the kernel values.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Jul 18 2017, 12:39 AM

It looks like ARCH_FLAGS is used only on MIPS? I'm missing something here since it seems the default MIPS ARCH_FLAGS is set in sys/conf/Makefile.mips, which has CFLAGS+=${EXTRA_FLAGS} $(ARCH_FLAGS)

Should have been done when the kernel side of this was committed.

This revision is now accepted and ready to land.Jul 19 2017, 1:45 PM

In D11633#241287, @emaste wrote:

It looks like ARCH_FLAGS is used only on MIPS? I'm missing something here since it seems the default MIPS ARCH_FLAGS is set in sys/conf/Makefile.mips, which has CFLAGS+=${EXTRA_FLAGS} $(ARCH_FLAGS)

It does seem to only be used on MIPS. The CFLAGS in Makefile.mips doesn't have any effect on module builds via buildkernel because that's in a clean sub-make invocation whose environment is governed by MKMODULESENV.

I ran into this on CheriBSD where I'm overriding the default -target via ARCH_FLAGS. The initial attempt was via CONF_FLAGS, but that doesn't make it into the trampoline or hack.c's compilation.

Closed by commit rS321256: Include ARCH_FLAGS in CFLAGS when building modules. (authored by brooks). · Explain WhyJul 19 2017, 10:06 PM

This revision was automatically updated to reflect the committed changes.