Page MenuHomeFreeBSD
Differential D11605

www/nginx: Pet Makefile
ClosedPublic
Actions

Authored by joneum on Jul 15 2017, 1:11 PM.
Tags
None
Referenced Files
F109484225: D11605.diff
Wed, Feb 5, 5:01 PM
Unknown Object (File)
Nov 29 2024, 4:02 PM
Unknown Object (File)
Nov 23 2024, 10:34 PM
Unknown Object (File)
Nov 23 2024, 7:56 AM
Unknown Object (File)
Nov 22 2024, 6:30 PM
Unknown Object (File)
Nov 20 2024, 2:08 AM
Unknown Object (File)
Nov 19 2024, 7:03 AM
Unknown Object (File)
Nov 17 2024, 9:53 PM
View All 87 Files
Subscribers
mat

Details

Reviewers
tz
rene
miwi
Commits
rP446008: - Pet portlint
Summary
  • Pet portlint
  • Add CONFLICTD
  • Also set portscout limit to avoid notices about www/nginx
  • Bump PORTREVISION

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 10509
Build 10919: arc lint + arc unit

Event Timeline

joneum created this revision.Jul 15 2017, 1:11 PM
Herald added a subscriber: mat. · View Herald TranscriptJul 15 2017, 1:11 PM
Harbormaster completed remote builds in B10509: Diff 30813.Jul 15 2017, 1:11 PM
miwi accepted this revision.Jul 16 2017, 2:21 PM
This revision is now accepted and ready to land.Jul 16 2017, 2:21 PM
Closed by commit rP446008: - Pet portlint (authored by joneum). · Explain WhyJul 16 2017, 2:44 PM
This revision was automatically updated to reflect the committed changes.
tz added inline comments.Jul 17 2017, 8:05 AM
head/www/nginx/Makefile
19 ↗(On Diff #30829)

Its already committed, but i just saw this Review.
I want to warn about the PORTSCOUT rule. Yes, its helpful to avoid false detections of 1.13.x releases. But now it will also ignore the next big release 1.14.x.
Have a look at my port games/wesnoth - it has exactly the same version-scheme.

mat added inline comments.Jul 17 2017, 1:30 PM
head/www/nginx/Makefile
19 ↗(On Diff #30829)

Yeah, limitw:1,even is what the doc says you should use :-)

joneum added inline comments.Jul 17 2017, 1:46 PM
head/www/nginx/Makefile
19 ↗(On Diff #30829)

There is www/nginx-devel
If version 14.x comes out, you can raise nginx-devel to version 14, and nginx to version 13. www/nginx is currently still managed by Sergey.
If version 14.x comes out, it must be advised first how to proceed. As long as PORTSCOUT makes sense.

tz added inline comments.Jul 17 2017, 1:53 PM
head/www/nginx/Makefile
19 ↗(On Diff #30829)

If version 1.14.x comes out, nginx-devel will be 1.15.x. nginx will become 1.14.x.
Please get familiar with the release cycle of your new port! :)

joneum added inline comments.Jul 17 2017, 2:02 PM
head/www/nginx/Makefile
19 ↗(On Diff #30829)

My mistake. Yes, I meant version 15.x - sorry :-)

Revision Contents
Changeset List

PathSize
www/
nginx/
18 lines

Diff 30813

View Options

www/nginx/Makefile

Loading...