Add NFIT tables to `acpidump -t` output

[emaste]

usr.sbin/acpi/acpidump/acpi.c

278–279

We can address this one separately I think (a separate commit prior to the NFIT support).

Also it should likely be if (subtable->Length < sizeof(ACPI_SUBTABLE_HEADER)) -- i.e., subtable length < 2 is invalid.

And finally, we can probably just do (instead of errx)

warn("invalid subtable length %d", subtable->Length);
return;

i.e., still print out other tables even if one is corrupt.

299

Should acpi_walk_nfit get a length validation as well?

1181

This one needs a different implementation -- I will discuss.

[emaste]

usr.sbin/acpi/acpidump/acpi.c

1178

Hmm, despite the rest of acpidump using %d, this should really be %u to correspond with the unsigned nfit->Type (and similarly for the rest of the printfs below)

1187

These ones are actually UINT64 (or uint64_t) so they need to be cast to (uintmax_t) and printed with 0x%016jx (Address, Length, and MemoryMapping)

I'd say the length should be in hex too.

1208–1209

%016jx for these two (size, offset)

1233

This one's not right: it's defined in the struct as LineOffset[1] but it's a placeholder for a variable sized array. Will discuss.

1237

variable length array here too

1242–1243

Vendor ID and Device ID in general are presented in hex -- probably 0x%04x

1245–1246

also hex

1253–1257

these are all 64-bit

1273–1276

four 64-bit values

1282

variable length

[ygy]

Update printf formats

[ygy]

Update printf format (again)

[emaste]

usr.sbin/acpi/acpidump/acpi.c

300

I realized after I shared the previous snippet with you that this should be warnx -- i.e., don't print a string corresponding to errno. Also by convention it's lower case i -- invalid subtable length

1208–1209

RegionSize and RegionOffset are 64-bit so need %016jx

1282

These ones still need to be fixed - I will explain.

[emaste]

usr.sbin/acpi/acpidump/acpi.c

300

oh, also should be %u here for unsigned argument

1184

We should probably check the return value in status as well. An error is practically not going to occur, so exiting on error ought to be sufficient. Could just be

if (status != uuid_s_ok)
        errx("uuid_to_string: status=%u", status)

1233

Can leave this one out at first as well - we need to address all three of these variable length entries in a similar way.

[kib]

usr.sbin/acpi/acpidump/acpi.c

1156

You may use array-designated-initializers there to explicitely specify array indexes for string names.

[ACPI_NFIT_TYPE_SYSTEM_ADDRESS] = "System Address",

1235

Use C-style comments /* */, instead of C++.

[ygy]

usr.sbin/acpi/acpidump/acpi.c

1156

This one definitely makes more sense. Do you think I should change the style for other occurrences in this file?

[emaste]

usr.sbin/acpi/acpidump/acpi.c

1156

I think that's reasonable, but submit a separate diff for that change, and we'll commit it first.

[kib]

usr.sbin/acpi/acpidump/acpi.c

1156

static const char * perhaps ?

1157

Indent is too large, use one tab.

[ygy]

Whitespace fixes