Differential D11445

Update to Subsonic 6 and drop maintainer ship.
ClosedPublic
Actions

Authored by jlh on Jul 2 2017, 10:45 AM.

Details

Reviewers

adamw

Group Reviewers

Ports Committers

Commits

rP446694: Update Subsonic from 5.3 to 6.0 and update license accordinly.

Summary

Review for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213298

Regarding the license: the Subsonic decided to switch to proprietary license
(http://forum.subsonic.org/forum/viewtopic.php?f=4&t=16604#p71128) but has
done a poor job in cleaning up the source tree to reflect so.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 10248
Build 10666: arc lint + arc unit

Event Timeline

jlh created this revision.Jul 2 2017, 10:45 AM

Herald added a subscriber: mat. · View Herald TranscriptJul 2 2017, 10:45 AM

Harbormaster completed remote builds in B10248: Diff 30314.Jul 2 2017, 10:45 AM

jlh added a reviewer: Ports Committers.Jul 2 2017, 10:45 AM

Update license comment as in D11444.

Harbormaster completed remote builds in B10385: Diff 30564.Jul 8 2017, 7:57 AM

Actually putting in license terms is certainly preferable, but in lieu of that setting LICENSE to NONE seems reasonable.

As long as this passes poudriere testport and portlint it looks good to me.

However if there's a version change shouldn't there at least be a distinfo change?

Oh, I missed the link to the bug which has the full diff and poudriere logs.

Approved.

Closed by commit rP446694: Update Subsonic from 5.3 to 6.0 and update license accordinly. (authored by jlh). · Explain WhyJul 26 2017, 8:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

www/

subsonic/

Makefile

9 lines

distinfo

5 lines

Diff 30314

View Options

www/subsonic/Makefile