Page MenuHomeFreeBSD

hexdump(1): Basic testing
ClosedPublic

Authored by kevans on Jun 20 2017, 3:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 3:45 PM
Unknown Object (File)
Wed, Apr 17, 12:13 AM
Unknown Object (File)
Mar 19 2024, 2:58 AM
Unknown Object (File)
Mar 17 2024, 7:01 AM
Unknown Object (File)
Dec 20 2023, 4:52 AM
Unknown Object (File)
Dec 12 2023, 8:42 PM
Unknown Object (File)
Oct 11 2023, 1:44 AM
Unknown Object (File)
Sep 24 2023, 3:26 AM
Subscribers
None

Details

Summary

Add some basic tests for hexdump(1)'s various output flags. Formatting
tests are omitted for this initial run as there are still some bugs to work out
there.

This covers -s flag testing on devices and non-devices that would have caught
breakage found in PR 219173 as well as other subtle breakage caused locally.

Test Plan

Run the tests as-is and with D10893 applied to address the other failures
that arise.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I've included three basic input files to test some corner cases: Single-line only (for most flags), column-sized aligned, and repeated lines -- I've used these in most test cases just for good measure.

Please MFC this change.

This revision is now accepted and ready to land.Jul 6 2017, 7:10 AM

Hi @cem,

Any thoughts on this one? =)

I'm not too familiar with hexdump, but if the tests pass and do what you expect, LGTM.

@cem Excellent! =) May I consider this approval for commit based on advice by emaste@ for this week?

w/ MFC After: 2 weeks, perhaps, since it's a low-impact/test change.

@cem Excellent! =) May I consider this approval for commit based on advice by emaste@ for this week?

Yep, go ahead.

I don't have any guidance on MFC timeframe, I don't MFC in general.

This revision was automatically updated to reflect the committed changes.

Some slight tweaks made before commit:

  • Correctly denote that two test cases are currently expected to fail; I was waiting until commit to add this in case it was addressed before-hand, and forgot to note that here. =(
  • Rename of *Cflag*.out to satisfy pre-commit hook naming clash detection