Page MenuHomeFreeBSD

Minor fixes to VPN section
ClosedPublic

Authored by sevan on Jun 11 2017, 12:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 9:48 PM
Unknown Object (File)
Jan 16 2024, 12:24 AM
Unknown Object (File)
Dec 20 2023, 4:22 AM
Unknown Object (File)
Nov 10 2023, 10:11 AM
Unknown Object (File)
Nov 7 2023, 10:32 PM
Unknown Object (File)
Nov 5 2023, 1:18 PM
Unknown Object (File)
Nov 4 2023, 9:53 PM
Unknown Object (File)
Oct 30 2023, 10:37 PM
Subscribers
None

Details

Summary

There is a double prompt in the IPsec vpn article at the moment.
e.g. # corp-net#
This patch attempts to address that by moving the hostname to the start of the line before using the root.prompt macro.
Fix spelling mistake picked up by igor.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9798
Build 10233: arc lint + arc unit

Event Timeline

Clarify that FreeBSD 11 comes with IPsec enabled by default, a custom kernel is only required on older releases.

A few comments.

en_US.ISO8859-1/books/handbook/security/chapter.xml
374

That is output from the utility. Is that fixed in there and we did not pick it up yet or did they fix it and have not updated this section?

2130

A   between &os; and 11 will be good to have.

en_US.ISO8859-1/books/handbook/security/chapter.xml
374

Ah, good catch, I didn't check the context. It was flagged by igor.

Drop corrections to command output.
Add non-breaking space.

sevan marked 2 inline comments as done.

We had encountered the same problem at BSDCan in another review. Seemed like a low-hanging fruit, but it isn't. ;-)

Indeed, need to check, check and check again :)

This revision was automatically updated to reflect the committed changes.
head/en_US.ISO8859-1/books/handbook/security/chapter.xml
2130 ↗(On Diff #29464)

I think we generally say "later" rather than "newer".

2131 ↗(On Diff #29464)

s/older releases/previous versions/

Rewriting to avoid the if/pause/then structure (and leaving out some markup for clarity):

Add these options to the custom kernel configuration file to add IPsec support to previous versions of &os;.
2132 ↗(On Diff #29464)

Please eliminate "the following" whenever it is used incorrectly, which is almost always. The only time to use it is when it can't be replaced with a simpler "this" or "these".

Hi Warren,
Apologies for the late reply to this, just wanted to follow up to say I've not forgotten about this review, will get the points you raised addressed next week if not this Sunday.

Sevan