Differential D11510

Minor fixes to VPN section Pt2
ClosedPublic
Actions

Authored by sevan on Jul 7 2017, 1:41 AM.

Tags

None

Referenced Files

	F167636798: D11510.id.diff
	Sun, Aug 23, 9:37 AM

	F167634991: D11510.diff
	Sun, Aug 23, 9:11 AM

	Unknown Object (File)
	Fri, Aug 21, 6:24 AM

	Unknown Object (File)
	Wed, Aug 19, 3:09 AM

	Unknown Object (File)
	Mon, Aug 17, 9:38 AM

	Unknown Object (File)
	Wed, Aug 12, 6:12 PM

	Unknown Object (File)
	Wed, Aug 12, 4:51 PM

	Unknown Object (File)
	Tue, Aug 11, 1:23 PM

Subscribers

None

Details

Reviewers

wblock
bcr

Commits

rD50456: Reword sentence about IPsec on legacy releases based on feedback from wblock.

Summary

Address points raised in D11143

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sevan created this revision.Jul 7 2017, 1:41 AM

sevan added a commit: rD50359: Add a note that FreeBSD 11 & newer have IPsec support enabled by default (no….Jul 7 2017, 1:42 AM

sevan added a parent revision: D11143: Minor fixes to VPN section.

sevan removed a commit: rD50359: Add a note that FreeBSD 11 & newer have IPsec support enabled by default (no….

sevan mentioned this in D11143: Minor fixes to VPN section.Jul 7 2017, 1:45 AM

A small suggestion on the original text...

en_US.ISO8859-1/books/handbook/security/chapter.xml
2130 ↗	(On Diff #30519)	This &os;   11 with the spaces before and after the   defeats the purpose of keeping the version number close to the word "FreeBSD" in case there is a line break. I know it was there before your change, but we might as well fix it while we're here: &os; 11 Your actual change looks fine to me.

Drop the spaces between the macros.

Harbormaster completed remote builds in B10371: Diff 30540.Jul 7 2017, 4:01 PM

sevan marked an inline comment as done.Jul 7 2017, 4:01 PM

wblock added inline comments.Jul 7 2017, 4:09 PM

en_US.ISO8859-1/books/handbook/security/chapter.xml
2131 ↗	(On Diff #30540)	Telling the reader that this is for earlier versions first seems important: For previous versions of &os;, add these options to a custom kernel configuration file and rebuild the kernel as shown in <xref

Re-edit based on feedback.

Harbormaster completed remote builds in B10372: Diff 30541.Jul 7 2017, 4:54 PM

wblock accepted this revision.Jul 7 2017, 5:09 PM

This revision is now accepted and ready to land.Jul 7 2017, 5:09 PM

Closed by commit rD50456: Reword sentence about IPsec on legacy releases based on feedback from wblock. (authored by sevan). · Explain WhyJul 7 2017, 5:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

en_US.ISO8859-1/

books/

handbook/

security/

7 lines

Diff 30544

head/en_US.ISO8859-1/books/handbook/security/chapter.xml

Loading...