Page MenuHomeFreeBSD

have WITH_CTF=YES imply DEBUG_FLAGS+=-g
ClosedPublic

Authored by markj on Nov 5 2014, 2:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 8:31 PM
Unknown Object (File)
Sat, Sep 7, 6:39 PM
Unknown Object (File)
Sat, Sep 7, 12:02 PM
Unknown Object (File)
Wed, Sep 4, 12:58 AM
Unknown Object (File)
Sun, Sep 1, 8:04 PM
Unknown Object (File)
Sun, Sep 1, 1:02 AM
Unknown Object (File)
Mon, Aug 19, 5:14 PM
Unknown Object (File)
Sat, Aug 17, 3:46 AM
Subscribers
None

Details

Summary

When WITH_CTF is set, we run ctfconvert on each object file after it's created, and ctfmerge on object files when linking. There's no point in doing this if there's no debug info, though. This change just sets DEBUG_FLAGS+=-g when WITH_CTF=YES. Additionally, I removed some superfluous checks in bsd.prog.mk and bsd.lib.mk.

Test Plan

Ran a "make tinderbox" with WITH_CTF=YES, no failures.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

markj retitled this revision from to have WITH_CTF=YES imply DEBUG_FLAGS+=-g.
markj updated this object.
markj edited the test plan for this revision. (Show Details)
markj added reviewers: imp, emaste.
imp edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Nov 5 2014, 6:53 AM
markj updated this revision to Diff 2321.

Closed by commit rS274200 (authored by @markj).