recv
ClosedPublic
Actions

Authored by woodsb02 on Jun 4 2017, 3:11 AM.

Details

Reviewers

wg
araujo
kmoore

Commits

rP442781: devel/py-libzfs: fix build on CURRENT

Summary

devel/py-libzfs: Fix build on FreeBSD head with compressed ZFS send/recv

Add extra patches to ignore compressed send/recv flags [1] [2], fixing build on head [3]
Fix issue returning zfs mount properties that need to be utf-8 [4]

[1] https://github.com/trueos/freebsd-ports/commit/804fc1221c31a6896f182adc796417d1ce2c388b
[2] https://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/lib/libzfs_core/common/libzfs_core.c?r1=317414&r2=317413&pathrev=317414
[3] https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20170529/478417.html
[4] https://github.com/trueos/freebsd-ports/commit/00da370342012d87331eae3d74ef6784ed8172be

Test Plan

poudriere testport passes on FreeBSD 10, 11, 12 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

woodsb02 created this revision.Jun 4 2017, 3:11 AM

Herald added subscribers: mat, delphij. · View Herald TranscriptJun 4 2017, 3:11 AM

Harbormaster completed remote builds in B9648: Diff 29182.Jun 4 2017, 3:11 AM

woodsb02 edited the summary of this revision. (Show Details)Jun 4 2017, 3:14 AM

woodsb02 edited the summary of this revision. (Show Details)

LGTM! But please, give sometime for @wg make the review of it too, he is the maintainer of this port.

Thanks!

This revision is now accepted and ready to land.Jun 4 2017, 3:27 AM

Thanks for the patch. I was wondering if we could push this upstream instead, its less work in general. I do have rw access to it so I'll try to do that the next few days.

In D11037#228956, @wg wrote:

Thanks for the patch. I was wondering if we could push this upstream instead, its less work in general. I do have rw access to it so I'll try to do that the next few days.

If it only takes a few days I don't see a problem with that. However, if it takes a while, we might want to just add the patch locally to the ports tree in the mean time, as it is preventing the iocage package from being available on FreeBSD head.

Note that if this goes upstream, it will need to include additional detection in the patch to discover the correct number of arguments for the lzc_send_space function as this patch is not backwards compatible to systems which do not yet have the compressed ZFS send/recv code. Currently this is being handled in this review by only including these py-libzfs patches on newer FreeBSD versions (after compressed send/recv was added).

Closed by commit rP442781: devel/py-libzfs: fix build on CURRENT (authored by wg). · Explain WhyJun 6 2017, 4:13 PM

This revision was automatically updated to reflect the committed changes.

wg mentioned this in rP442781: devel/py-libzfs: fix build on CURRENT.

I have updated the upstream and the port (r442781) with the 12-current build fix. I have not committed the mountpoint patch because I do not believe that is the right solution for anything, it should be returning encoded (bytes).

Thanks!