flag to switch off bootp()

[kczekirda]

Summary

In most scenarios we can switch off bootp() but requires user activity to set the flag.

Sponsored by: Oktawave

[kczekirda]

small cleanup

[bapt]

Is is really worth it (skipping one bootp call?)

[kczekirda]

It's the only one from pxeloader. I can safety remove the same from iPXE and in summary, during boot chain I have less a half of DHCP request in network. Let's say grain by grain...

[tsoome]

In D11007#228039, @kczekirda wrote:

It's the only one from pxeloader. I can safety remove the same from iPXE and in summary, during boot chain I have less a half of DHCP request in network. Let's say grain by grain...

I seems you just brought back the old code, so it seems to be ok in that regard. I have to say I am not overly happy about the preprocessor spaghetti and another chunk of code which is not built by default and therefore will not get tested. So I'll rather remain in neutral position. IMO the less such exceptions, the better and considering those "user controlled" features the loader already has - I really do not see much value in most of those;)

[bapt]

I think it is worth a discussion on arch@ before reading this kind of build time option.
@kczekirda do you start the discussion?

[kczekirda]

In my point of view I would like to use this flag in /etc/make.conf instead of patching local src. Having this flag allow users to use it no only for me. It's only a proposal, so the end of this story only up to you.

@bapt - Yes, I do.

[oshogbo]

Can we abandom this review?