Page MenuHomeFreeBSD

german/wordpress: Fix Checksum
ClosedPublic

Authored by joneum on May 30 2017, 9:30 AM.

Details

Summary
  • Fix checksum because of changes in the language files
  • Bump PORTREVISION

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

Old commit was 22.05.2017, reload 24.05.2017, see: https://de.wordpress.org/releases/

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

So, the file changed ? It had this checksum and size before, and now it has this one ? If so, please read how to handle this.

That page is not very long, it would be nice to have it in the actual commit message, in english.

In D10990#227667, @mat wrote:

That page is not very long, it would be nice to have it in the actual commit message, in english.

"Fix checksum because of changes in the language files" this is the message

Oh, ok. You should probably bump PORTREVISION too.

please add the port bump in the commit log.

This revision is now accepted and ready to land.May 31 2017, 2:14 PM
This revision was automatically updated to reflect the committed changes.

If the summary is supposed to be the commit message, it is awful.

Please read http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

A commit message is supposed to be about explaining why you are doing what you are doing. It is really not about what you are doing. What you are doing can be seen by looking at the diff. Imagine yourself reading it in a year and wondering, ok, but why did he change all this.

In this case, it should be something like:

"Upstream rerolled the distfiles with some updates"