Page MenuHomeFreeBSD
Differential D10990

german/wordpress: Fix Checksum
ClosedPublic
Actions

Authored by joneum on May 30 2017, 9:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 2:37 AM
Unknown Object (File)
Fri, Jan 17, 9:41 PM
Unknown Object (File)
Jan 4 2025, 10:12 PM
Unknown Object (File)
Nov 19 2024, 12:44 PM
Unknown Object (File)
Oct 4 2024, 7:08 PM
Unknown Object (File)
Oct 4 2024, 2:21 PM
Unknown Object (File)
Oct 2 2024, 4:50 AM
Unknown Object (File)
Oct 2 2024, 1:46 AM
View All 90 Files
Subscribers
mat

Details

Reviewers
tz
miwi
rene
Commits
rP443505: MFH: r442213
rP442213: - Fix checksum because of changes in the language files
Summary
  • Fix checksum because of changes in the language files
  • Bump PORTREVISION

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

Old commit was 22.05.2017, reload 24.05.2017, see: https://de.wordpress.org/releases/

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joneum created this revision.May 30 2017, 9:30 AM
Herald added a subscriber: mat. · View Herald TranscriptMay 30 2017, 9:30 AM
Harbormaster completed remote builds in B9570: Diff 29001.May 30 2017, 9:30 AM
joneum added reviewers: tz, miwi, rene.May 30 2017, 9:32 AM
mat added a comment.May 30 2017, 2:36 PM

So, the file changed ? It had this checksum and size before, and now it has this one ? If so, please read how to handle this.

joneum edited the summary of this revision. (Show Details)May 30 2017, 7:35 PM
mat added a comment.May 30 2017, 8:26 PM

That page is not very long, it would be nice to have it in the actual commit message, in english.

joneum added a comment.May 30 2017, 8:54 PM
In D10990#227667, @mat wrote:

That page is not very long, it would be nice to have it in the actual commit message, in english.

"Fix checksum because of changes in the language files" this is the message

mat added a comment.May 31 2017, 7:49 AM

Oh, ok. You should probably bump PORTREVISION too.

joneum updated this revision to Diff 29059.May 31 2017, 8:22 AM

Add PORTREVISION

joneum edited the summary of this revision. (Show Details)May 31 2017, 8:22 AM
miwi accepted this revision.May 31 2017, 2:14 PM

please add the port bump in the commit log.

This revision is now accepted and ready to land.May 31 2017, 2:14 PM
joneum edited the summary of this revision. (Show Details)May 31 2017, 3:02 PM
Closed by commit rP442213: - Fix checksum because of changes in the language files (authored by joneum). · Explain WhyMay 31 2017, 3:04 PM
This revision was automatically updated to reflect the committed changes.
mat added a comment.May 31 2017, 3:05 PM

If the summary is supposed to be the commit message, it is awful.

Please read http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

A commit message is supposed to be about explaining why you are doing what you are doing. It is really not about what you are doing. What you are doing can be seen by looking at the diff. Imagine yourself reading it in a year and wondering, ok, but why did he change all this.

In this case, it should be something like:

"Upstream rerolled the distfiles with some updates"

Revision Contents
Changeset List

PathSize
head/
german/
wordpress/
1 line
6 lines

Diff 29081

View Options

head/german/wordpress/Makefile

Loading...
View Options

head/german/wordpress/distinfo

Loading...