Page MenuHomeFreeBSD

irc/konversation-kde4: Update to 1.7.2 and rename to irc/konversation
ClosedPublic

Authored by rakuco on May 26 2017, 12:18 PM.

Details

Summary

The title should say it all: update to the latest release (which is KF5-based) and drop the "-kde4" suffix from the port.

Test Plan

It runs fine on my KDE4 desktop.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rakuco created this revision.May 26 2017, 12:18 PM

I generated the diff here with git diff, so some of the moves are not represented correctly. I'll take care of doing it the right way when landing.

tcberner edited edge metadata.May 26 2017, 12:26 PM

In the version in the development repo (konvresation-1.6.2) we have a patch to src/viewer/viewcontainer.cpp adding #include <cstdlib> -- is this not needed anymore with 1.7.2?

It built fine on HEAD and 10.3 jails. Do you remember what issue it was supposed to fix and on what platform?

tcberner accepted this revision.May 26 2017, 12:37 PM

Unfortunately I can't remember, I got this patch originally from Marie Loise. But if it works on 10 and 12, it should be fine.

This revision is now accepted and ready to land.May 26 2017, 12:37 PM
fluffy added a subscriber: fluffy.May 26 2017, 1:07 PM

Unfortunately I can't remember, I got this patch originally from Marie Loise. But if it works on 10 and 12, it should be fine.

I remember some dances with <cstdlib>, it was required with clang3.[89] and i386 platform. AFAIR, clang40+ isn't affected, 'cause hooks <cstdlib> automagically.

This revision was automatically updated to reflect the committed changes.