Page MenuHomeFreeBSD

vmxnet3 crash when LRO is enabled
ClosedPublic

Authored by avg on May 23 2017, 4:23 PM.

Details

Summary

The crash can occur when all of the following conditions are true:

  • a packet consists of multiple segements (requires LRO enabled)
  • there has been a failure to allocate an mbuf for the packet and the packet has to be dropped
  • a host (vmware) still owned at least one segment of the packet, so the driver had to wait for another interrupt to proceed to discarding the remaning segment(s)

The work was sponsored by Panzura who run into the problem.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

avg created this revision.May 23 2017, 4:23 PM
avg edited the summary of this revision. (Show Details)May 23 2017, 4:25 PM
avg added a subscriber: network.May 23 2017, 4:28 PM
avg added a comment.May 24 2017, 10:22 AM

@rstone this is based on the discussion that we had on the IRC and the suggestion you made.

rstone accepted this revision.May 24 2017, 7:23 PM
This revision is now accepted and ready to land.May 24 2017, 7:23 PM
This revision was automatically updated to reflect the committed changes.