Page MenuHomeFreeBSD

Change RUN and BUILD Depends
ClosedPublic

Authored by joneum on May 18 2017, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 1:41 PM
Unknown Object (File)
Sep 29 2024, 4:16 AM
Unknown Object (File)
Sep 28 2024, 1:35 PM
Unknown Object (File)
Sep 26 2024, 2:57 AM
Unknown Object (File)
Sep 22 2024, 7:17 AM
Unknown Object (File)
Sep 22 2024, 6:11 AM
Unknown Object (File)
Sep 8 2024, 6:01 AM
Unknown Object (File)
Sep 5 2024, 2:19 AM
Subscribers

Details

Summary
  • Chance RUN und BUILD Depends to DNS2 (DNS is EOL)
  • Add License PHP30

PR: 218762
Submitted by: rene
Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/D10804

Test Plan

net/pear-Net_DNSBL % portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 2 warnings found.

poudriere testport:

10amd64
10i386
11amd64
11i386
12.0-CURRENT r318899 amd64
12.0-CURRENT r318400 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rene requested changes to this revision.May 19 2017, 6:05 PM

Can you include the PR (218762) in the commit message for archival purposes?

Also, change "Reported by: " to "Submitted by: rene" (for committers, we usually just include write the login name)

For the LICENSE, can you add the LICENSE_FILE from WRKSRC ?

This revision now requires changes to proceed.May 19 2017, 6:05 PM

Hey Rene,

thank you for the feedback.

What you mean with "Can you include the PR (218762) in the commit message for archival purposes?"?
Is this not okay into the Commit Message:
PR: 218762

I will chance Reported by: " to "Submitted

About LICENSE_FILE: There is no License file inside the package. That's why I have not added WRKSRC.

joneum edited the summary of this revision. (Show Details)

Adding "PR: 218762" to the commit log is indeed fine.

This revision is now accepted and ready to land.May 25 2017, 9:36 AM
This revision was automatically updated to reflect the committed changes.