xen/blkfront: correctly detach a disk with active users
ClosedPublic
Actions

Authored by royger on May 17 2017, 2:05 PM.

Tags

None

Referenced Files

	F172357821: D10772.id.diff
	Thu, Sep 17, 10:42 PM

	F172313320: D10772.diff
	Thu, Sep 17, 4:16 PM

	Unknown Object (File)
	Thu, Sep 10, 5:17 AM

	Unknown Object (File)
	Sat, Sep 5, 11:51 PM

	Unknown Object (File)
	Sat, Sep 5, 8:58 AM

	Unknown Object (File)
	Sat, Sep 5, 8:41 AM

	Unknown Object (File)
	Sat, Sep 5, 5:55 AM

	Unknown Object (File)
	Sat, Sep 5, 1:45 AM

View All Files

Subscribers

manu

Details

Reviewers

cperciva
bapt

Commits

rS318520: xen/blkfront: correctly detach a disk with active users

Summary

Call disk_gone when the backend switches to the "Closing" state and blkfront
still has pending users. This allows the disk to be detached, and will call
into xbd_closing by itself when the geom layout cleanup has finished.

Reported by: bapt
Sponsored by: Citrix Systems R&D
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger created this revision.May 17 2017, 2:05 PM

bapt accepted this revision.May 17 2017, 2:39 PM

This revision is now accepted and ready to land.May 17 2017, 2:39 PM

you can add tested by: manu

In D10772#223139, @bapt wrote:

you can add tested by: manu

Yep,

Thanks for working on this.

Closed by commit rS318520: xen/blkfront: correctly detach a disk with active users (authored by royger). · Explain WhyMay 19 2017, 8:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

xen/

blkfront/

blkfront.c

11 lines

Diff 28553

View Options

head/sys/dev/xen/blkfront/blkfront.c

xen/blkfront: correctly detach a disk with active usersClosedPublicActions